Change in ovirt-engine[ovirt-engine-4.1]: frontend: set DAD to false when entity is unavailable
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: set DAD to false when entity is unavailable
......................................................................
frontend: set DAD to false when entity is unavailable
Patch a2e073845dc5485b36a6bad00c1a8e63c238342b indeed fixed a UI bug as
requested, but it also made it impossible to:
1. Navigate to new block storage domain window.
2. Set DAD to true.
3. Navigate to file domain and create one.
Since the last time DAD was available it was set to true, and since only
the availability of DAD is set to false, the value remains true and the
frontend tries to create a file domain with DAD = true ,which is
impossible, and the user gets an error message.
This patch sets DAD to false whenever it is unavailable.
Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b
Bug-Url: https://bugzilla.redhat.com/1458568
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/78012
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-log-collector[master]: fix missing table of contents.
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: fix missing table of contents.
......................................................................
fix missing table of contents.
Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-hosted-engine-ha[master]: jsonrpc: validate the connection with ping command
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: jsonrpc: validate the connection with ping command
......................................................................
jsonrpc: validate the connection with ping command
Use ping command instead of Host.getHardwareInfo to
validate the status of the jsonrpc connection.
Change-Id: I56a78f55c7dd53e1632a0ce4f51c3f985997e4cc
Bug-Url: https://bugzilla.redhat.com/1457471
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/util.py
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56a78f55c7dd53e1632a0ce4f51c3f985997e4cc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Ignore unrelated responses from server
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Ignore unrelated responses from server
......................................................................
Ignore unrelated responses from server
When using for example Kerberos authentication the server can return to
the client more then one response. The client is interested only in last
response which contains the information about the authentication, if it
was successfull, so this patch add logic to ignore the headers which
don't belong to last response.
Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f
Related-to: https://bugzilla.redhat.com/1459254
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit af184796a6c15e7f3b3148c7edf7d053c5fe6142)
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[master]: Ignore unrelated responses from server
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Ignore unrelated responses from server
......................................................................
Ignore unrelated responses from server
When using for example Kerberos authentication the server can return to
the client more then one response. The client is interested only in last
response which contains the information about the authentication, if it
was successfull, so this patch add logic to ignore the headers which
don't belong to last response.
Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f
Related-to: https://bugzilla.redhat.com/1459254
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-log-collector[master]: sos: add an option to limit the maximum log size
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: add an option to limit the maximum log size
......................................................................
sos: add an option to limit the maximum log size
If log-size is specified, limit the maximum size of the logs
collected from each host to log-size, and additionally limit the
maximum number of days to 1
Change-Id: I0e4921c407bac0fc7abd15c1de188e91ef44f82c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020790
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
---
M src/__main__.py
M src/ovirt-log-collector.8
2 files changed, 35 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e4921c407bac0fc7abd15c1de188e91ef44f82c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: cleanup unused parameter from RngUtils
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: cleanup unused parameter from RngUtils
......................................................................
core: cleanup unused parameter from RngUtils
The parameter usage was removed in 3d23f6bdf81c3f8d32ec512141fd058131fa0e6f but
since this patch was meant to be backported, it was kept as simple as possible.
This patch cleans the unused parameter up.
Change-Id: If9c181174b760711a8f67388f93ad52704159fed
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java
7 files changed, 8 insertions(+), 11 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9c181174b760711a8f67388f93ad52704159fed
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: webadmin: Memory hotunplug button and missing specParams
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Memory hotunplug button and missing specParams
......................................................................
webadmin: Memory hotunplug button and missing specParams
Memory hot unplug button is disabled for devices that misses specParams
required to perform hot unplug - 'size' and 'node'.
Bug-Url: https://bugzilla.redhat.com/1452631
Change-Id: I7d9fdab555097018bea4197b12eb3e60dfedeef5
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugCell.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
3 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76985
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d9fdab555097018bea4197b12eb3e60dfedeef5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-hosted-engine-setup[master]: Provide clearer error when failing to retrieve vm.conf from ...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Provide clearer error when failing to retrieve vm.conf from storage.
......................................................................
Provide clearer error when failing to retrieve vm.conf from storage.
Change-Id: Id7b7d91d30625875856316fb8c4f26cd655ff94f
Bug-Url: https://bugzilla.redhat.com/1434209
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M src/bin/hosted-engine.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7b7d91d30625875856316fb8c4f26cd655ff94f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: engine: Use AuditLogImpl for logging events
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use AuditLogImpl for logging events
......................................................................
engine: Use AuditLogImpl for logging events
Instead of instantiating a command only for the sake of logging, the
AuditLogImpl can be used instead for the exact purpose.
In addition, the exact code was used for logging both host set memory
and host set cpu actions. Code was reused for that purpose.
Change-Id: I15fb72bfeb747b71ef5ede0026b26696ee68c025
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 14 insertions(+), 26 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15fb72bfeb747b71ef5ede0026b26696ee68c025
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months