Change in ovirt-hosted-engine-ha[v2.1.z]: build: ovirt-hosted-engine-ha-2.1.2
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-2.1.2
......................................................................
build: ovirt-hosted-engine-ha-2.1.2
- Updated deps
- Aligned with downstream spec file
Change-Id: I3185e479d03be3ff1a984f6bd932b3a3eb7000d1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 20 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3185e479d03be3ff1a984f6bd932b3a3eb7000d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
7 years, 5 months
Change in ovirt-release[ovirt-4.1]: ovirt-release41-4.1.3_rc1
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-release41-4.1.3_rc1
......................................................................
ovirt-release41-4.1.3_rc1
Change-Id: I808b02e7bfc22fc8883310186a19ab1d54bd814f
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-release41.spec.in
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77948
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I808b02e7bfc22fc8883310186a19ab1d54bd814f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: change order of validations in RemoveStorageDomainCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: change order of validations in RemoveStorageDomainCommand
......................................................................
core: change order of validations in RemoveStorageDomainCommand
Currently when attempting to remove a storage domain, part of the
validation process attempts to mount a storage domain to check if
it's attached to a DC and then disconnects. If the storage is already
attached, disconnecting from it may trigger a master domain
reconstruction (if it's the master) and it shouldn't do that.
The patch moves the isStorageDomainAttached check to the end of the
validation since we can fail earlier by querying the database and
discovering the domain is already attached without triggering the
reconstruction.
Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc
Bug-Url: https://bugzilla.redhat.com/1444120
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Benny Zlotnik: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77866
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Add QCOW2 header version for QcowCompat enum.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add QCOW2 header version for QcowCompat enum.
......................................................................
core: Add QCOW2 header version for QcowCompat enum.
Add mapping and field for QcowCompat enum to indicate the QCOW2 header
version in a QCOW volume.
Change-Id: Ie7a915175324407531a6a87325e30de11a764720
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/QcowCompat.java
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7a915175324407531a6a87325e30de11a764720
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Set QCOW compat from downloaded Glance image.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set QCOW compat from downloaded Glance image.
......................................................................
core: Set QCOW compat from downloaded Glance image.
Set QCOW compat version in disk image based on the downloaded image from
Glance.
Change-Id: I6b266d938870d8b1adbd76d9042cabc8fa0fef20
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b266d938870d8b1adbd76d9042cabc8fa0fef20
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Update QCOW version of downloaded glance image.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Update QCOW version of downloaded glance image.
......................................................................
core: Update QCOW version of downloaded glance image.
Fetch QCOW version of glance image once it finish to be downloaded,
and update the QCOW version in the DB.
Change-Id: I62d2e399263a1b6edbfb97df3f13dbf020ab0ccc
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62d2e399263a1b6edbfb97df3f13dbf020ab0ccc
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Refactor of setting disk attributes.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Refactor of setting disk attributes.
......................................................................
core: Refactor of setting disk attributes.
Engine updates the new disk image with updated size and actual size
attributes based on the downloaded image retrieved from Glance.
The engine reads the image using inputstream and therefore
makes it hard to maintain for extra fields to update.
The proposed patch refactors the update of the disk image fields, to
be done inside the parsing method, making diskImage a parameter in
the method signature.
Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java
1 file changed, 20 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77670
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Add QCOW version validations for ImportRepoImage.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add QCOW version validations for ImportRepoImage.
......................................................................
core: Add QCOW version validations for ImportRepoImage.
Add validation in DiskImagesValidator for disk with
compatibility level of 1.1 (QCOW2_V3) in storage pool
format type less than V4.
Change-Id: Ia4f48fd8472011b29907458beaf38880441242ba
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 107 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4f48fd8472011b29907458beaf38880441242ba
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[sdk_4.1]: Ignore unrelated responses from server
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Ignore unrelated responses from server
......................................................................
Ignore unrelated responses from server
When using for example kerberos authentication the server can return
to the client more then one response. The client is interested only
in last response which contains the information about the
authentication, if it was successfull, so this patch add a logic to
ignore the headers which doesn't belong to last response.
Change-Id: I8025b471a9c05618f273c726a02a60017434ee58
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1459254
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 5b7458c618083ed4eb41b4a67fd0614724cb3fc1)
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/tests/test_connection_create.py
2 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77944
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8025b471a9c05618f273c726a02a60017434ee58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: update VdsDynamic dns configuration after setupnetworks
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: update VdsDynamic dns configuration after setupnetworks
......................................................................
core: update VdsDynamic dns configuration after setupnetworks
After setupnetworks, setupnetworks is called. If
DnsResolverConfiguration is changed, update VdsDynamic with new
DnsResolverConfiguration.
Change-Id: I31d6431bad9cf323dd7c8af656f97969d67eb623
Bug-Url: https://bugzilla.redhat.com/1451261
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
3 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31d6431bad9cf323dd7c8af656f97969d67eb623
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months