2:14 a.m.
Roy Golan has submitted this change and it was merged.
Change subject: engine: Limited use of CPU Profiles by user
......................................................................
engine: Limited use of CPU Profiles by user
Adding/Updating VM using REST API now checks that the user has
permissions for the CPU Profile of the VM.
This applies whether the CPU profile is changed or not. It
means that even if the CPU Profile is not changed or the user tries to
create a VM in a cluster where he/she doesn't have permissions for any
CPU Profile, he/she will not be able to Create/Update the VM.
This change effects the following Commands in the engine:
AddVmCommand, UpdateVmCommand.
In case no Cpu Profile was specified in the REST API request, Any CPU
Profile that the user has permissions for will be used to comply with
the old behaviour of the system.
Change-Id: Ic187e1815fbb2334e4eca7140e6b2a5493059bae
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 83 insertions(+), 21 deletions(-)
Approvals:
Tomer Saban: Verified
Roy Golan: Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/50818
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic187e1815fbb2334e4eca7140e6b2a5493059bae
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>