Sandro Bonazzola has submitted this change and it was merged.
Change subject: networking: set VLAN on top level network object
......................................................................
networking: set VLAN on top level network object
The /cluster/{cluster:id}/networks/{network:id} resource
only supports updates of the cluster itself, which is weird.
For any other update, like the VLAN, you need to sue the top
level /networks/{network:id} resource which can be addressed
only by id.
Pooling to check network status and vlan id since
setting vlan id is async.
Detecting the interface name if the management bridge
was created in the past by a previous attempt.
Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e
Bug-Url:
https://bugzilla.redhat.com/1291083
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
2 files changed, 117 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/53065
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>