Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VmGeneralModel empty string validation ...................................................................... webadmin: VmGeneralModel empty string validation Replaced the test for domain's emptiness from StringHelper.stringsEquals(vm.getCustomProperties(), "") to a simpler StringHelper.isNullOrEmpty(vm.getCustomProperties()). Note that although there is a slight difference in semantics, there is no point in having null custom properties, and it's implicitly assumed to be not-null in other places of the code. Change-Id: Ib45cf6fb428cd6750a1264ca45a8b332420bc57f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib45cf6fb428cd6750a1264ca45a8b332420bc57f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server