Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpgradeOvirtNodeInternalCommandTest: Clear OVirtNodeInfo
......................................................................
core: UpgradeOvirtNodeInternalCommandTest: Clear OVirtNodeInfo
OVirtNodeInfo stores a Config value in a static context, so relying
on it means this test is susceptible to outside interference if other
tests use it but neglect to clean it up, causing unexpected test
failures.
This patch add a safe-guard to the test by clearing the instance
before the test is run.
Change-Id: I451fd2dfae005e23c49dcd829facee66e6531f1e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommandTest.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/65011
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I451fd2dfae005e23c49dcd829facee66e6531f1e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>