Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: CreateAllSnapshotsFromVm - CreateAllCinderSnapshots execution
......................................................................
core: CreateAllSnapshotsFromVm - CreateAllCinderSnapshots execution
Currently CreateAllSnapshotsFromVm always executes CreateAllCinderSnapshots.
The execution may lead to FK constraint violation - this patch alters
the command to execute it only if the snapshot contains cinder disks.
This fix is for 3.6 branch only, as cinder support is on tech preview
on that version this patch fixes the issue for snapshot the includes image disks.
On the master branch the code is very different so this issue isn't relevant.
Change-Id: Iffb8fad4db3a2cea4000dff2491b40308cc2e986
Bug-Url:
https://bugzilla.redhat.com/1357361
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 16 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit
https://gerrit.ovirt.org/61316
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffb8fad4db3a2cea4000dff2491b40308cc2e986
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>