Change in ovirt-engine[master]: webadmin: edit pool dialog freezes when when SD is down (#83...
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: edit pool dialog freezes when when SD is down (#839594)
......................................................................
webadmin: edit pool dialog freezes when when SD is down (#839594)
https://bugzilla.redhat.com/839594
Have a pool on a storage domain which is down.
Go to pool tab, press edit. The window will
stack forever.
Fixed in a way, that the dialog opens the same way as if
the SD would not be down. When the OK button is pressed,
an error comes back from the server.
Fixed by avoiding NPEs and ClassCastExceptions on different
places.
This patch also refactors the Edit method to use the
GetVmDataByPoolId query, which is more efficient than the
AsyncDataProvider.GetVmList and selecting the first element.
Change-Id: Ic9635873a04c71bdf94a011a27dd47cb5c9b259b
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
2 files changed, 243 insertions(+), 218 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9635873a04c71bdf94a011a27dd47cb5c9b259b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>