Change in ovirt-engine[master]: core: Set command return value when building CoCo command fr...
Moti Asayag has submitted this change and it was merged.
Change subject: core: Set command return value when building CoCo command from entity
......................................................................
core: Set command return value when building CoCo command from entity
The CommandCoordinatorImpl.buildCommand() method is called via
retrieveCommand() from several callbacks and the result is used to
persist changes to the command.
In some instances, such as AddDiskCommand, the command may have
previously set a return value that a caller may need to retrieve. When
the callbacks are executed and persist an update of the returned
command, the return value is cleared. This causes errors in the calling
code, and in the particular case where this was discovered, makes Image
Upload unable to identify its newly-created disk image.
Change-Id: Idf1067fffe69ed69d45606c0e656f06772864754
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf1067fffe69ed69d45606c0e656f06772864754
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>