Arik Hadas has submitted this change and it was merged.
Change subject: core: VmDeviceMonitoring save hash after updateFromFullList()
......................................................................
core: VmDeviceMonitoring save hash after updateFromFullList()
In VmDeviceMonitoring, after updateFromFullList(), on the next polling
cycle only devices hash is updated, FullList is not called again.
But, because isVmDevicesChanged() simply returned false and the VM
wasn't touched, the new hash wasn't stored in the DB.
This patch adds new return value for isVmDevicesChanged() - HASH_ONLY -
to update hash in the DB without refreshing the device list. For the
same goal added a new list of VMs whose hash needs to be saved.
Change-Id: I5daad3d73f67a578cd0df4b56b104cf791a5fe2e
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 41 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/53552
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5daad3d73f67a578cd0df4b56b104cf791a5fe2e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>