Change in ovirt-engine[master]: setup: Write the answer file if file path is valid
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: Write the answer file if file path is valid
......................................................................
setup: Write the answer file if file path is valid
Added a exception handling to make sure answer file gets
written only if the file path is valid one. If the path
is invalid, instead of erroring out and marking the whole
setup as failed, it shows a warning and setup is marked as
completed successfully.
A valid use case is calling "engine-setup --generate-answer
=root/engine-answer.txt". In this case the current working
dir does not contain a directory with name root.
In the above scenario, earlier engine setup used to display an
error saying "No such file or directory: '<CurrDir>/root/
engine-answer.txt'". Also the overall engine-setup output used
to report "[ ERROR ] Execution of setup failed".
With the fix, now the output looks as below -
[WARNING] [Errno 2] No such file or directory:
'<CurrDir>/root/engine-answer.txt'
and the overall engine setup reports a success as below -
"[ INFO ] Execution of setup completed successfully"
Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f
Bug-Url: https://bugzilla.redhat.com/1089067
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py
1 file changed, 49 insertions(+), 31 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Shubhendu Tripathi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server