Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Fix cp and add firewalld dependency
......................................................................
node: Fix cp and add firewalld dependency
Currently, in the installation/update cp -u will update the
existing backup file which can cause misleading conf.
To avoid this case, first remove any existing
backup file before copying the current firewalld conf to backup.
In addition a dependency on firewalld is added, to ensure
that firewalld completed all logic around the configuration
files and we can modify them to our needs.
Previously firewalld could be instaleld after the host-node pkg
which would lead to situation that host-node modified the firewalld.conf
but firewalld overwrote it again, once it got installed.
Change-Id: I4beaeb0b77d9bccea2ba0d6de84973d6c2c8efb5
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/54037
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4beaeb0b77d9bccea2ba0d6de84973d6c2c8efb5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>