From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: build: NlsCheck boolean expression
......................................................................
build: NlsCheck boolean expression
Use the boolean expression startAnnotation directly instead of
comparing it to true, as per Java's best practices.
Change-Id: I737b156c253e1f2ad5b5467130ac78936b85df7b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/74434
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I737b156c253e1f2ad5b5467130ac78936b85df7b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>