Change in ovirt-engine[master]: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions
......................................................................
core: RunVmValidatorTest#mockVmPropertiesUtils exceptions
Test set-up methods should throw exceptions if they fail to set up the
test, making it error out instead of silently catching the exception and
having the test fail in some hard to debug way later. Moreover, a test
(or any piece of reasonable software, for that matter), should certainly
not just dump the stacktrace to stderr (instead of using some proper
logging framework).
Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>