Alona Kaplan has submitted this change and it was merged.
Change subject: engine: check hotplugged nics for duplicated pci address also when vm is
not running
......................................................................
engine: check hotplugged nics for duplicated pci address also when vm is not running
Hotplugged nics should be checked for duplicated pci addresses
also when the vm is not running. Duplicated address could happen
in the following scenario:
1. Run vm
2. Add a nic, an address will be assigned on the vm
3. Unplug nic, the address will be remembered in engine.
4. Plug another nic, the same address could be assigned.
5. Power off vm.
6. Plug first nic again
7. During vm power on, both nics will have the same address
Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef
Bug-Url:
https://bugzilla.redhat.com/1199782
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/50387
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>