Change in ovirt-engine[master]: core: separate tests differing with bond mode
Alona Kaplan has submitted this change and it was merged.
Change subject: core: separate tests differing with bond mode
......................................................................
core: separate tests differing with bond mode
I have some issues with this test in following patch(do not pass whole
Bond from UI, but only required data), and it would be harder to
fix that problem differently than it's done in this patch.
There are several tests, which tests same stuff for all bond options.
These tests saves some computational time by reinitializing only bond
instance between tests, but this is cause of my problems, since I'm
replacing datatype of parameters.newOrModifiedBonds, so I'd have to
update inside of loop not only bond, but also all bonds in given
collection. So I opted to completely separate test for each bond mode.
This way is of course less
performant(not significantly though), but does not assume correct
behavior of validator being tested. Before this modification, tested
subject had to 'cooperate' and neither do touch 'bond' passed in
parameters nor to store data from it in any its [validators] inner
structures. Doing so whould probably cripple test, and test
should probably not assume this is not happening if it's possible to
write it like that.
I also introduced ErrorCollector, which will report all failing
bondmodes and not just first one.
Change-Id: I654b60f8456a16f5925658a84f8b44d5c7a7b5e4
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 47 insertions(+), 35 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I654b60f8456a16f5925658a84f8b44d5c7a7b5e4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>