Change in ovirt-engine[master]: webadmin: detach handlers on hide
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: detach handlers on hide
......................................................................
webadmin: detach handlers on hide
- Before this patch the change event handlers were detached
when the object containing them would be detached from the
DOM, this could happen many times and it would cause the
handlers to be detached before we wanted them to. This patch
detaches the handlers when the popup is hidden instead of
detached from the DOM.
Change-Id: I56de07f80cbb21fe6362d6df488defe7422cebfb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1164744
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractModelBoundTreePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java
5 files changed, 45 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56de07f80cbb21fe6362d6df488defe7422cebfb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server