From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. (
https://gerrit.ovirt.org/80271 )
Change subject: core: VdsStaticDao#testIfExistsHostThatMissesNetworkInCluster
......................................................................
core: VdsStaticDao#testIfExistsHostThatMissesNetworkInCluster
VdsStaticDaoTest should test VdsStaticDao and not rely on other DAO's
implementation, which may break and wrong fail the test.
This patch cleans up the test by removing the dependency on
InterfaceDao and re-writes the test so it only depends on the data
set up by the test fixtures.
Change-Id: Ib8c682bdf885fdb941613249f3e41335ec950400
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDaoTest.java
1 file changed, 12 insertions(+), 51 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/80271
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8c682bdf885fdb941613249f3e41335ec950400
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>