Change in ovirt-engine[master]: core: RemoveSnapshot preview validation
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveSnapshot preview validation
......................................................................
core: RemoveSnapshot preview validation
In RemoveSnapshot, moved the validation that the VM is not
in preview from ImagesHandler to SnapshotValidator, which is a more
logical place for it.
This patch contains the aforementioned change in RemoveSnapshot's code,
and the required adjustments to the mocking done in
RemoveSnapshotCommandTest to allow it to continue functioning.
Note: This patch is part of a series of patches aimed at removing the
preview validation from ImagesHandler altogether.
Change-Id: Ib42871fecd4738a77c657f07a464c8dd68dee592
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib42871fecd4738a77c657f07a464c8dd68dee592
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Matthias Heinz <matthias.heinz(a)goobernetworks.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>