Allon Mureinik has submitted this change and it was merged.
Change subject: core: RunVmValidatorTest spying
......................................................................
core: RunVmValidatorTest spying
Use spying instead of anonymously extending RunVmValidatorTest in order
to make the code easier to read and follow.
Not only does this technique follow the generally accepted practices for
testing code in the project, it also sets up the groundwork for some
extra strictness, provided in the following patch.
Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
1 file changed, 7 insertions(+), 19 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/57493
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>