Change in ovirt-engine[master]: core: cache host's numa nodes
Arik Hadas has submitted this change and it was merged.
Change subject: core: cache host's numa nodes
......................................................................
core: cache host's numa nodes
Analyze of profiling dumps shows that a significant portion
of the CPU time is spent on getting the numa nodes on the host.
This can be improved by querying them only once in the host
polling instead of doing that per-VM.
We can cache it because it is not expected to change so it will
be queried once and not per-polling operation, but it would
maybe make sense to query that nodes along with the VM numa
nodes in one query per-polling operation.
So for now the optimization is just to reduce the frequency
of the query of the host's numa nodes to be once per-polling.
Change-Id: I5d72ab207f861ca8e050068d101c998343cffc60
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MemoizingSupplier.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
3 files changed, 55 insertions(+), 12 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/53169
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d72ab207f861ca8e050068d101c998343cffc60
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>