Tal Nisan has submitted this change and it was merged.
Change subject: core: EndExternalJobCommandTest @Spy annotation
......................................................................
core: EndExternalJobCommandTest @Spy annotation
Rework the test so the command is spied with an annotation and the thing
that changes between the tests is the result the DAO returns for the
constant jobid.
Besides being clearer, this approach sets the scene for injecting the
DAO later on in the patch series.
Change-Id: Ic67b7d8373e5fc451ca2e856cc11543b2dac40ef
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalJobCommandTest.java
1 file changed, 13 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/64790
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic67b7d8373e5fc451ca2e856cc11543b2dac40ef
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>