Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Replace inner variable references in failure messages ...................................................................... webadmin: Replace inner variable references in failure messages Currently the message processing code ignores variables that were added by expanding other variables. This is not consistent with the handling in AuditLog. This patch fixes that and makes the behaviour the same. The only risk here is that we have an expansion cycle, but that is under our control and should not happen. As an usage example think about the expansion of the following messages: "$filterType internal" "$hostName dev-03" "$filterName Network" "$networkNames test" "$detailMessage network(s) ${networkNames} are missing" "The host ${hostName} did not satisfy ${filterType} filter ${filterName} because ${detailMessage}." This is related to the our improvement of how we report scheduling failures. Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077627 Signed-off-by: Martin Sivak <msivak(a)redhat.com&gt; --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com&gt; Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com&gt; Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com&gt; Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com&gt; Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com&gt; Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com&gt; Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server