Eyal Edri has submitted this change and it was merged. Change subject: lago-pipeline: refactoring ...................................................................... lago-pipeline: refactoring 1. Assert 'sha1' and 'REFSPEC' parameters are passed to the job, otherwise fail. This will be done inside a preliminary stage, thus allowing to use the proper Jenkins stage failure mechanism, and avoid messing with buildResult parameters. Did not include assertion for gerrit parameters, as we use this flow for github only at the moment. 2. Use 'params' instead of 'env' where applicable. 3. Use the new 'stage' syntax. 4. Remove code duplication and unify functions. 5. Use the new milestone syntax to guarantee only one job gets to the deploy stage. 6. Moved main() to the top of the code. 7. JJB variables will be substituted into the main function call. Change-Id: I13f3b9ac30266a6372e9b0e34de8511629f9453c Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com&gt; --- M jobs/confs/groovy-scripts/standard-pipeline.groovy 1 file changed, 70 insertions(+), 139 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f3b9ac30266a6372e9b0e34de8511629f9453c Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com&gt; Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com&gt; Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt; Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com&gt; Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com&gt; Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com&gt; Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com&gt; Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;