Tal Nisan has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructure - determineSourceImageGroup() ...................................................................... core: CloneImageGroupVolumesStructure - determineSourceImageGroup() determineSourceImageGroup() is used to determine the source image group (which may differ between the first volume and the rest of the volume chain in case the disk is based on a template). The method had two issues: 1. It returned the image id instead of the disk id. 2. It used image.getImageTemplateId() to determine if the disk is based on template. When disk snapshots are created their image template id field is copied from the parent volume, which means that all the chain has the same value in tht field - only the first volume needs to be created as based on the template disk. This patch changes the check to use the template disk id only when the template volume is the parent of the volume by checking that getParentId() equals to getImageTemplateId(). Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a Bug-Url: https://bugzilla.redhat.com/1429184 Bug-Url: https://bugzilla.redhat.com/1429170 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/73595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;