Moti Asayag has submitted this change and it was merged. Change subject: core: rename and use literal ip in getMigrationNetworkIp ...................................................................... core: rename and use literal ip in getMigrationNetworkIp all currently-supported versions of vdsm expect what rfc#2732 calls "literal ip addresses" as for the dstqemu parameter of the migrate verb. as part of the ipv6 migration effort, it is required to use ip addresses that are uri compatible, i.e. ip literals. the ipv4 variation requires no further modifications, however if there's no ipv4 and ipv6 is used, complying to rfc#2732 is necessary. the function was renamed to both indicate and explain the string modification. Change-Id: I5e3349f349e737b5198bb5100e76c8f25699e9bf Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Leon Goldberg: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e3349f349e737b5198bb5100e76c8f25699e9bf Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com&gt; Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com&gt; Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;