Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79519 ) Change subject: core: Clean up CINDERStorageHelper transaction handling ...................................................................... core: Clean up CINDERStorageHelper transaction handling Most of the calls to CINDERStorageHelper are done from non-transactive commands, where it makes no sense to explicitly wrap the DAO calls in new transactions. In the one place it's created with force, simply having the DAO calls inlined there would use the current transaction, which makes more sense here too. Additionally, this change removes exception catching of DAO calls and allows propagating them upwards, where they're actually useful. Change-Id: I506ae16fed51d66df6cab46ea1f590556600bb8b Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/CINDERStorageHelper.java 2 files changed, 8 insertions(+), 50 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506ae16fed51d66df6cab46ea1f590556600bb8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;