From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix GWT debug compilation errors
......................................................................
webadmin,userportal: Fix GWT debug compilation errors
1. updated SLF4J class overrides from gwt-extension project
(those are messing with Java classpath when executing GWT
debugger via gwt-maven-plugin)
- sadly, we cannot remove them since the "common" backend
code (used by frontend) uses SLF4J for logging :-(
2. updated frontend classes to not use SLF4J API
3. modified WebAdmin & UserPortal pom.xml files
- added `jboss-concurrency-api` (provided scope) to avoid
class loading issues (this is due to DashboardDataServlet
being part of frontend.jar)
- removed unnecessary `maven-compiler-plugin` declaration
since it's applied anyway
All frontend code should NOT use SLF4J API.
Instead, all frontend code should use java.util.logging API
directly, which is the standard way of doing logging in GWT.
Change-Id: I573e14332ab10fd5cb844c6fe03e1614c32fcc72
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
M
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/StringFormat.java
M
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/slf4j/Logger.java
M
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/slf4j/LoggerFactory.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
7 files changed, 36 insertions(+), 31 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Scott Dickerson: Verified
--
To view, visit
https://gerrit.ovirt.org/68073
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I573e14332ab10fd5cb844c6fe03e1614c32fcc72
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>