Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveImage as sync operation ...................................................................... core: RemoveImage as sync operation * When performing RemoveImage command, the engine can treat the vds command DeleteImageGroup as synchronous operation instead of asynchronous (as it does before this patch). The call might be treated as synchronous because when the call returns, the image is considered to be non existent on the storage side, we shouldn't wait for the deletion to end before proceeding with the related db updates. *When receiving an ImageDoesNotExist error from vdsm during remove image - proceed with removing the image as it doesn't exist. *known issue - when performing remove disk, in case of an engine crash after RemoveImage completed but before the vm's ovf generation was incremented - the ovf won't be updated. That's a non issue as the ovf can contain also today images that where deleted from the storage and can be fixed in a separate patch to reduce the 'noise' here. Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8 Bug-Url: https://bugzilla.redhat.com/884635 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 9 files changed, 84 insertions(+), 92 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com&gt; Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;