Moti Asayag has submitted this change and it was merged.
Change subject: core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand()
......................................................................
core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand()
Fix findbugs issue -
GetTagsByUserIdQuery.java:14, DLS_DEAD_LOCAL_STORE, Priority: Low
Dead store to tempVar in
org.ovirt.engine.core.bll.GetTagsByUserIdQuery.executeQueryCommand()
This instruction assigns a value to a local variable, but the value is not read or used
in
any subsequent instruction. Often, this indicates an error, because the value computed is
never used.
Note that Sun's javac compiler often generates dead stores for final local variables.
Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these
false positives.
Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/8682
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>