Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: sub menu positioning
......................................................................
userportal,webadmin: sub menu positioning
- When a sub menu (such as the reports) would show up and
there was no enough room to show the menu to the right and
below the menu, it would move the sub menu higher so it can
fit on the screen, but it would not take into account that
the bottom of the sub menu needs to line up with the bottom
of the item of menu that is associated with the sub menu.
This patch does take the height of the menu item into account
when calculating the position of the sub menu.
Change-Id: I8500c8737ec24d3ade438c6924620eedc7b4fc55
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1184983
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/PopupUtils.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
2 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/37297
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8500c8737ec24d3ade438c6924620eedc7b4fc55
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server