Roy Golan has submitted this change and it was merged. Change subject: core: Introduce postConstruct for commands ...................................................................... core: Introduce postConstruct for commands Replace the need to call DbFacade or other interaction with the command dependencies during the constructor. It is ensured (by CommandFactory) that all the command injected dependencies are already in place. so instead of: public DoThisCommand(P p) { DbFacade.getInstance().getVmDao... } we would: @Override protected postConstruct() { dbFacade.getVmDao... } Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 Signed-off-by: Roy Golan <rgolan(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/37599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com&gt; Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com&gt; Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server