Martin Sivák has submitted this change and it was merged. Change subject: upgrade: adding a docstring for _is_conf_volume_there ...................................................................... upgrade: adding a docstring for _is_conf_volume_there The code to detect the configuration image is not trivial so it's better to describe it. Since nothing calls prepareImage on the configuration image before we discover it, the volume shouldn't be available but it is so it's better to keep track of this behavior. Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com&gt; --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;