Change in ovirt-engine[master]: core: [rmd] RefreshPoolSingleAsyncOperation
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [rmd] RefreshPoolSingleAsyncOperation
......................................................................
core: [rmd] RefreshPoolSingleAsyncOperation
removed refobject usage from RefreshPoolSingleAsyncOperation
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
Change-Id: I9e353b95d9622b1ede68e6284f5805643ff8b5a8
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java
2 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e353b95d9622b1ede68e6284f5805643ff8b5a8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: [rmd] remove RefObject from BooleanCompat
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [rmd] remove RefObject from BooleanCompat
......................................................................
core: [rmd] remove RefObject from BooleanCompat
BooleanCompat turned out to be redundant in the process as no methods
left in it, so it was deleted.
Change-Id: I0b081dd0530e244faa6c4353789e046538c2cc72
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/BooleanCompat.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
2 files changed, 4 insertions(+), 44 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b081dd0530e244faa6c4353789e046538c2cc72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal: GetIrsImageList->GetAllIso(Floppy)ImagesListBySt...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: GetIrsImageList->GetAllIso(Floppy)ImagesListByStoragePoolId
......................................................................
userportal: GetIrsImageList->GetAllIso(Floppy)ImagesListByStoragePoolId
Replaced the calling of the AsyncDataProvider.GetIrsImageList
to GetAllIso(Floppy)ImagesListByStoragePoolId in:
- New/Edit VM dialog
- Run Once dialog
Also the UserVmModel has been deleted as it is never used.
Change-Id: I7f2e7a09146685bb2d522dcd068e711d32e95d10
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
8 files changed, 157 insertions(+), 2,279 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f2e7a09146685bb2d522dcd068e711d32e95d10
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webamdin, userportal: SPICE USB filter
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webamdin,userportal: SPICE USB filter
......................................................................
webamdin,userportal: SPICE USB filter
Adding missing usbfilter.txt file fetching mechanism.
Fixes BZ 800773 -
https://bugzilla.redhat.com/show_bug.cgi?id=800773
Change-Id: I1c9549a4546f0fc19db0feb34259a09872550fef
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
3 files changed, 30 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9549a4546f0fc19db0feb34259a09872550fef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Adding test for VdcQueryType
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Adding test for VdcQueryType
......................................................................
core: Adding test for VdcQueryType
Adding test for queries, which validates whether the query name has
been added to the VdcQueryType enum, and if so if it was added with the
appropriate name based on the query name without the suffix.
Change-Id: I6591190bc5f4a7d9445eea1ecd34da0c79564e25
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6591190bc5f4a7d9445eea1ecd34da0c79564e25
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: Gluster command enhancements
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster command enhancements
......................................................................
engine: Gluster command enhancements
- extending all gluster vds command from AbstractGlusterBrokerCommand
- Setting vdsErrors in return value
- Setting executionFailedMessages with vdsError in bll commands
Change-Id: I7a3f9c28c11849831bacc3a0f682ce50c3373f21
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResetGlusterVolumeOptionsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeVDSCommand.java
9 files changed, 27 insertions(+), 16 deletions(-)
Approvals:
Selvasundaram: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a3f9c28c11849831bacc3a0f682ce50c3373f21
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: ApplicationConstants in AbstractSanStorageList
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: ApplicationConstants in AbstractSanStorageList
......................................................................
webadmin: ApplicationConstants in AbstractSanStorageList
Moving ApplicationConstants variable to parent
class AbstractSanStorageList as static (fixes a NPE).
Change-Id: Ib3e7dde7b23b77a87c16f38a15f8820c44ef73a9
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/AbstractSanStorageList.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/SanStorageLunToTargetList.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/SanStorageTargetToLunList.java
3 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3e7dde7b23b77a87c16f38a15f8820c44ef73a9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Resource interfaces for Gluster Volume(s)
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
......................................................................
restapi: Resource interfaces for Gluster Volume(s)
- Resource interfaces for following resources:
* Gluster Volumes Collection (clusters/{cluster_id}/glustervolumes)
* Gluster Volume Resource (clusters/{cluster_id}/glustervolumes/{volume_id})
* Gluster Bricks Collection (clusters/{cluster_id}/glustervolumes/{volume_id}/bricks)
* Gluster Brick Resource (clusters/{cluster_id}/glustervolumes/{volume_id}/bricks/{brick_id})
- Collection to parent mapping in LinkHelper
Change-Id: I97503702a4fc5eeedeaa44ad1aba7cd35919521a
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumesResource.java
5 files changed, 259 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Shireesh Anjal: Verified
--
To view, visit http://gerrit.ovirt.org/3364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97503702a4fc5eeedeaa44ad1aba7cd35919521a
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.glynn(a)gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Added Gluster entities in REST schema
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Added Gluster entities in REST schema
......................................................................
restapi: Added Gluster entities in REST schema
Includes xml schema elements for gluster volumes,
bricks, and options.
Change-Id: I93c4df85068c3ed1ebfa35124bdfc2ae8f4482c8
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/AccessProtocol.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterState.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterVolumeType.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/TransportType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
6 files changed, 274 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Shireesh Anjal: Verified
--
To view, visit http://gerrit.ovirt.org/3360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93c4df85068c3ed1ebfa35124bdfc2ae8f4482c8
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.glynn(a)gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Introducing RandomUtilsSeedingRule
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Introducing RandomUtilsSeedingRule
......................................................................
core: Introducing RandomUtilsSeedingRule
The first revision of RandomUtilsSeedingRule, intended to allow logging
and overriding RandomUtils' seed for unit tests.
This patch includes the new @Rule itself and a usage example.
If this approched is accepted by the community and the patch is
merged, I'll submit further patches that utilize this rules in tests
that use RandomUtils.
Change-Id: I9b61902aca7986752e61530dc4afb1b9a9293c2d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MultiValueMapUtilsTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtilsSeedingRule.java
2 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4357
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b61902aca7986752e61530dc4afb1b9a9293c2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months