August 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Prevent Reporting UNKNOWN Network (#849163)

by msalem＠redhat.com

Muli Salem has submitted this change and it was merged. Change subject: core: Prevent Reporting UNKNOWN Network (#849163) ...................................................................... core: Prevent Reporting UNKNOWN Network (#849163) https://bugzilla.redhat.com/849163 This patch makes sure the Network name is only removed from the list of bad Networks, if the Bond status is true, meaning we do not need the Network name to be printed out to the Audit log. Change-Id: I0a8349b23c3b578d33118113ff618740f1d9ab8e Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a8349b23c3b578d33118113ff618740f1d9ab8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Time zones not ordered well (#850696)

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Time zones not ordered well (#850696) ...................................................................... engine: Time zones not ordered well (#850696) https://bugzilla.redhat.com/850696 WebAdmin -> Virtual Machines tab -> new server/desktop -> Initial Run -> Time Zone The content of this check box is not ordered well if the selected VM operating system is windows. The problem was in GetTimeZonesQuery which had the TimeZoneTimeExtractComperator not correctly implemented: The compare method returned only 0 and 1, but never -1, even when the second arg was smaller than the first one. This worked in JDK6, but the JDK7's Collections.sort() checks if the comparator is implemented correctly, and if not, it does not sort the list at all. Fixed by fixing the compare method to work according to the contract. Change-Id: Iecae3f868d6b3bc6663459367d1bd424b920a3fb Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTimeZonesQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecae3f868d6b3bc6663459367d1bd424b920a3fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: StorageFormatType cleanup

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: StorageFormatType cleanup ...................................................................... core: StorageFormatType cleanup - import java.util instead of fqn - intValue renamed to value (since it is actually a String, not an int) Change-Id: I7e09124c888e113e1473adf8eb7f6a9f93104917 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageFormatTypeTest.java 2 files changed, 21 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e09124c888e113e1473adf8eb7f6a9f93104917 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Add nic via guideme sets the wrong nic name (#8469...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add nic via guideme sets the wrong nic name (#846997) ...................................................................... webadmin: Add nic via guideme sets the wrong nic name (#846997) https://bugzilla.redhat.com/846997 Sometimes, when adding nic via guide me, the nic is created with the default parameters and not with the parameters the user specified in the add nic dialog. The reason - In guide me model- when adding a nic there are async queries for nics and networks. When the nics and networks arrives from the backend (nic!=null && networks!=null) the adding procedure should continue and open the add-nic dialog. In case the networks query is ready before the nics query- the adding procedure continue (because nics were already initialized before) and opens the dialog. Then when the nics query is done the adding procedure resets the windowModel and tries to open a dialog (it doesn't succeed because there is already an open one). But when the user clicks ok on the add-nic dialog the GuideMe model uses the new window model (with default values) set after the nic query was done and not the model with which the dialog was originally opened. The solution is to reset nics and networks before the starting the queries. Change-Id: I0445c014831967524f23ae5847b388354b0e7555 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0445c014831967524f23ae5847b388354b0e7555 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Host Intrfaces menu doesn't change by DC version (...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Host Intrfaces menu doesn't change by DC version (#838491) ...................................................................... webadmin: Host Intrfaces menu doesn't change by DC version (#838491) https://bugzilla.redhat.com/838491 The setEntity in HostIntefaceListModel was overriden and did nothing if the entityId didn't change. That's why the HostInterfaceModel remained with old dc/cluster data and the actions weren't updated correctly. Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: can set port mirroring on Edit vnic also for 3.0 (...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) ...................................................................... webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) https://bugzilla.redhat.com/846025 Port mirroring should be disabled in Edit vnic dialog if the cluster version is 3.0 or beneath. Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: [SetupNetwork] redundant line break in bottom chec...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetwork] redundant line break in bottom checkboxes(#849099) ...................................................................... webadmin: [SetupNetwork] redundant line break in bottom checkboxes(#849099) https://bugzilla.redhat.com/849099 redundant line break in Verify connectivity between Host and Engine. Should use "%" instead of "px". Change-Id: I4ca0953f74bf77b0c0536347c474facc34598f12 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 3 files changed, 22 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca0953f74bf77b0c0536347c474facc34598f12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core:Add comma instead of dot (related to BZ848094)

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core:Add comma instead of dot (related to BZ848094) ...................................................................... core:Add comma instead of dot (related to BZ848094) Use comma instead of dot. Change-Id: Id185bb1aeb095a5cddc5fe75c2b45ba1c91d699e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id185bb1aeb095a5cddc5fe75c2b45ba1c91d699e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in AddSANStorageDomainC...

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in AddSANStorageDomainCommand. ...................................................................... core: Remove deprecated StringHelper in AddSANStorageDomainCommand. Replaced StringHelper with StringUtils Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: build: support files with spaces in tarball

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: build: support files with spaces in tarball ...................................................................... build: support files with spaces in tarball Change-Id: I39bbe4f5fa76c4b494ded9586d54fdc0cf6f2156 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39bbe4f5fa76c4b494ded9586d54fdc0cf6f2156 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

12 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2012