January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change logging from warn to err
by tnisan＠redhat.com 07 Jan '13

07 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: change logging from warn to err ...................................................................... core: change logging from warn to err Fix bug 879322 make a statement logged in err instead of warning. In addition, remove unused constant and rename private methods according to java conventions. Change-Id: Ia853f5a3ef3e4e364d3c98807d3d1b35e094894e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879322 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 25 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia853f5a3ef3e4e364d3c98807d3d1b35e094894e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: if filter: header is set, use query instead of sear...
by mpastern＠redhat.com 07 Jan '13

07 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: if filter: header is set, use query instead of search (#869334) ...................................................................... restapi: if filter: header is set, use query instead of search (#869334) When the filter option is specified the api query should not throw a insufficient permissions exception. Instead the query should return a list of objects that the user has permissions for. Change-Id: I54b79dc86e4f6d6b28c5e720200b093d246f0806 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=869334 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/dbscripts/audit_log_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDbUsersQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllEventMessagesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AuditLogDaoMocker.java 18 files changed, 143 insertions(+), 24 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54b79dc86e4f6d6b28c5e720200b093d246f0806 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update image statuses to OK on upgrade.
by mlipchuk＠redhat.com 07 Jan '13

07 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update image statuses to OK on upgrade. ...................................................................... core: Update image statuses to OK on upgrade. Update statuses from LOCKED to OK only if no tasks exists, and use it on each upgrade with no specific flag. Change-Id: I31c6437ef4d757d9ec59ef93cb448735fc741a28 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/dbscripts/delete_async_tasks_and_compensation_data.sql A backend/manager/dbscripts/upgrade/03_00_0430_update_locked_status_to_ok.sql 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31c6437ef4d757d9ec59ef93cb448735fc741a28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: fix allinone version to 3.2 for dc/cluster default version
by juan.hernandez＠redhat.com 07 Jan '13

07 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: fix allinone version to 3.2 for dc/cluster default version ...................................................................... fix allinone version to 3.2 for dc/cluster default version Change-Id: I5ae937b05766cdd7d00c65cbbb70b7a9ce46300a Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae937b05766cdd7d00c65cbbb70b7a9ce46300a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Gianluca Cecchi <gianluca.cecchi(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB - Insure that there are no null values...
by emesika＠redhat.com 07 Jan '13

07 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: DB - Insure that there are no null values... ...................................................................... core: DB - Insure that there are no null values... DB - Insure that there are no null values for entity_type column in vm_static before forcing it to be not NULL Adding update all records that are not marked as 'VM" to 'TEMPLATE' Change-Id: I8a149d55f6c4a4900f12f9b96c6f1c2368697498 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0100_migrate_templates_to_vm_static.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a149d55f6c4a4900f12f9b96c6f1c2368697498 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB Adding missing check to fix...
by emesika＠redhat.com 07 Jan '13

07 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: DB Adding missing check to fix... ...................................................................... core: DB Adding missing check to fix... DB Adding missing check to fix duplicate key violation Checking if key exists before attempt to add a record to disks table. This fixes an attempt to insert duplicate key to the disks table. Change-Id: Ia1f8befcaad0e20d7259980cb0e5f2e116964245 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0070_populate_disks_table.sql 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1f8befcaad0e20d7259980cb0e5f2e116964245 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB - check if contraint exists before...
by emesika＠redhat.com 07 Jan '13

07 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: DB - check if contraint exists before... ...................................................................... core: DB - check if contraint exists before... DB - check if constraint exists before attempting to drop it. Check in the upgrade script that constraint exists before attempting to drop it. Since this fix must run also for Postgres 8.4.x we can not simply use the 'IF EXISTS' clause for that constraint since that is supported only from Postgres 9.x Change-Id: I8356df36a53f06751779f7e221bdcf4b1dfa9de7 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0100_migrate_templates_to_vm_static.sql 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8356df36a53f06751779f7e221bdcf4b1dfa9de7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Do not send ticket back in case of operation error
by mpastern＠redhat.com 07 Jan '13

07 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Do not send ticket back in case of operation error ...................................................................... restapi: Do not send ticket back in case of operation error Do not return a ticket using REST API if operation fails, e.g. user doesn't have permission to VM Change-Id: I8bc4d0c6ed48005978d333d28c7bec66d076c511 Bug-Url: https://bugzilla.redhat.com/867920 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bc4d0c6ed48005978d333d28c7bec66d076c511 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: drop usage of util.getDefault()
by Alon Bar-Lev 06 Jan '13

06 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: drop usage of util.getDefault() ...................................................................... vdsm: bridge: drop usage of util.getDefault() Change-Id: Iba23c97ab98bf0581d909dad328dc44184aa73ce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/bridge.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba23c97ab98bf0581d909dad328dc44184aa73ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: support the async URLGrabber
by Alon Bar-Lev 06 Jan '13

06 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: support the async URLGrabber ...................................................................... packagers: yum: support the async URLGrabber yum uses python-urlgrabber to grab files, but does not allow setting the meter for parallel fetch. The detection if parallel fetch is to be used is not configurable, so we hack a private member to force blocking download. The progress callback broke because of python-urlgrabber or yum change, hopping this modification will be sufficient to avoid future behaviour breakage. Change-Id: I41557b1ed5f44d685e5305909b3914e2fcf4ce0a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41557b1ed5f44d685e5305909b3914e2fcf4ce0a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0