November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Remove NICs from VM Guide Me
by iheim＠redhat.com 04 Nov '13

04 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Remove NICs from VM Guide Me ...................................................................... webadmin: Remove NICs from VM Guide Me Since virtual network interfaces can now be added in the add VM dialog itself, there's no longer need for them to take part in the following Guide Me flow. Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b Bug-Url: https://bugzilla.redhat.com/1024249 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideDiskModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 11 insertions(+), 178 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Change audit log value to be unique
by iheim＠redhat.com 04 Nov '13

04 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Change audit log value to be unique ...................................................................... core: Change audit log value to be unique There is a duplicate value code in the auditLogType file, which can cause wrong audit log to be presented. The proposed patch fix them it so it will be unique. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Related to Bug-Url: https://bugzilla.redhat.com/1021210 Change-Id: I81e7074807396541d041a170adeff49949b9d731 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81e7074807396541d041a170adeff49949b9d731 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: log.info outgoing notifications
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: tools: log.info outgoing notifications ...................................................................... tools: log.info outgoing notifications log.info recipient and subject. log.debug message body. Change-Id: I8b4fca0623351729cd918d5e8dd79d1b861f224f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020760 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b4fca0623351729cd918d5e8dd79d1b861f224f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: pki: fixed subject usage
by sbonazzo＠redhat.com 04 Nov '13

04 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: fixed subject usage ...................................................................... pki: fixed subject usage Fixed the env variable to be used while generating the spice pki certificate. Change-Id: I3e48c691ca59df430dea64785c6f5ac62531a9ad Bug-Url: https://bugzilla.redhat.com/1025259 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e48c691ca59df430dea64785c6f5ac62531a9ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: handle bridge on additional hosts
by sbonazzo＠redhat.com 04 Nov '13

04 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: handle bridge on additional hosts ...................................................................... packaging: setup: handle bridge on additional hosts Previously on an additional host hosted-engine-setup checked for ip addr of the bridge instead of the ip addr of any existing device. But on additional host the bridge creation is done by the manager when adding the host. Enabled the NIC selection for bridge creation also on additional hosts if the bridge is not found and use its ip Bug-Url: https://bugzilla.redhat.com/1025253 Change-Id: I81a5edada72d397c3ce30410d903840b1392034e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 28 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a5edada72d397c3ce30410d903840b1392034e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: fix race in CommandAsyncTask
by iheim＠redhat.com 04 Nov '13

04 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: fix race in CommandAsyncTask ...................................................................... engine: fix race in CommandAsyncTask The race was the following: 1: [thread 1] CommandAsyncTask's constructor reaches the point "entityInfo.AttachTask(this)" while the "_multiTasksByCommandIds" still contains one task. After this it gets interrupted 2: [thread 2] the CommandAsyncTask.handleEndActionResult is executed in meanwhile and issues the "_multiTasksByCommandIds.remove(commandInfo.getCommandId());" 3: [thread 1] the first thread continues the execution and calls the "entityInfo.AttachTask(this);" 4: [thread 1] the CommandAsyncTask.ConcreteStartPollingTask() is called. It asks for the GetCommandMultiAsyncTasks which returns null (because thread 2 have deleted it) and fails on NPE on the next line Fixed by moving all the code which needs to be synchonized to the sync block. It will not cause any deadlocks because the CommandMultiAsyncTasks.AttachTask does not use the original _lockObject (nor directly nor indirectly). Change-Id: Id265df1c1843b976c6f8d65729fd6717c3df3c76 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015638 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id265df1c1843b976c6f8d65729fd6717c3df3c76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Allow activate hosts that support the engine's version
by ofrenkel＠redhat.com 04 Nov '13

04 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: Allow activate hosts that support the engine's version ...................................................................... Allow activate hosts that support the engine's version HandleVdsVersion prevented activation of any hosts with vdsm version that was not supported by the engine (SupportedVDSMVersions). This patch adds validation for the installed Vdsm's supportedENGINEs value. If one of the two is supported we can allow the activation. Vdsm minor version might bumped up after new present feature, major version doesn't change in such case. Under the vdsm capabilities we define the supported engine's version to allow working with new features even though the engine's version wasn't changed. If the vdsm version supports the engine's version its enough to allow the activation. This check was omitted as part of http://gerrit.ovirt.org/#/c/17719 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016461 Change-Id: I70b10f9ede37de858df0aa88185c75f2d84fc141 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b10f9ede37de858df0aa88185c75f2d84fc141 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removal unneeded query
by tnisan＠redhat.com 04 Nov '13

04 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: removal unneeded query ...................................................................... core: removal unneeded query The given load is unneeded and it's data isn't used - therefore it's being removed. Change-Id: Ib81147871cc546b40750cccdca4f04b21d467eb1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib81147871cc546b40750cccdca4f04b21d467eb1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: remove usage of /ca.crt uri
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: pki: remove usage of /ca.crt uri ...................................................................... pki: remove usage of /ca.crt uri we have new servlet that can serve resources, so we can use this servlet instead of per resource URI. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Change-Id: Iac544335e1a0c01388eae23405d83bdac4704d34 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 3 files changed, 55 insertions(+), 41 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac544335e1a0c01388eae23405d83bdac4704d34 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: services: pki-resource: rename RFC4716->OPENSSH-PUBKEY
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: services: pki-resource: rename RFC4716->OPENSSH-PUBKEY ...................................................................... services: pki-resource: rename RFC4716->OPENSSH-PUBKEY better and more correct term. Change-Id: I1a173f9daa7840d05444e54ac6b4afcedabb598e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a173f9daa7840d05444e54ac6b4afcedabb598e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0