April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RemoveVdsCommandTest - proper setup
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsCommandTest - proper setup ...................................................................... core: RemoveVdsCommandTest - proper setup Fixed several set up issues in this test: * Using MockitoRunner instead of calling the annotation initialization explicitly. * Having a different GUID each test instead of a constant * Stop hiding the command member Change-Id: I03f327f958506016a561e26df5a949aab306c266 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 15 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03f327f958506016a561e26df5a949aab306c266 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Del ImagesHandler.isDomainWithinThresholds
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Del ImagesHandler.isDomainWithinThresholds ...................................................................... core: Del ImagesHandler.isDomainWithinThresholds ImagesHandler.isDomainWithThresholds is useless method - all it does is invoke a StorageDomainValidator, which could (and should!) be done directly. This patch replaces the single usage it had with a direct call to the validator, and removes this method, along with the validate method that's only called from it. Change-Id: I7a0c776e9798d6128a3aac4400e1a22b3df84b56 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 35 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a0c776e9798d6128a3aac4400e1a22b3df84b56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: service: rename engine service file to match serv...
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: service: rename engine service file to match service name ...................................................................... packaging: service: rename engine service file to match service name Always install sysv and systemd, this makes the packaging directory consistent with the naming scheme and the outcome on filesystem after installation. Change-Id: I2f10ef8329dd8f2f872f7c6dfebd01f73b151a0c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in R packaging/services/ovirt-engine-logging.properties.in R packaging/services/ovirt-engine.py R packaging/services/ovirt-engine.systemd.in R packaging/services/ovirt-engine.sysv.in R packaging/services/ovirt-engine.xml.in 7 files changed, 18 insertions(+), 16 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f10ef8329dd8f2f872f7c6dfebd01f73b151a0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove uselss file
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: remove uselss file ...................................................................... packaging: remove uselss file Change-Id: Ibe8c3f67b0c95e7d33b24ccb8da9ed5568c346fa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D packaging/todo 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe8c3f67b0c95e7d33b24ccb8da9ed5568c346fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move man pages to own directory
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: move man pages to own directory ...................................................................... packaging: move man pages to own directory Change-Id: Ia107e24c0d0bbf1ceb40916bcaf34111e66b7335 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile R packaging/man/engine-manage-domains.8 R packaging/man/engine-setup.8 R packaging/man/engine-upgrade.8 4 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia107e24c0d0bbf1ceb40916bcaf34111e66b7335 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVdsHooksById2Query
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVdsHooksById2Query ...................................................................... core: Remove GetVdsHooksById2Query GetVdsHooksByIdQuery and GetVdsHooksById2Query are completely identical except for the usage of different APIs of VdsHooksParser. Since GetVdsHooksById is not used anywhere, it is removed, and GetVdsHooksById2 loses it "2" and get a name the better suits conventions (not to mention common sense). This patch includes: 1. Removing the old GetVdsHooksByIdQuery class and renaming GetVdsHooksById2Query to take its place. 2. Removing the old GetVdsHooksById constant in the VdsQueryTye enum, and renaming GetVdsHooksById2 to take its place. 3. Clearing up the VdsHooksParser class from methods with "2" in their name - either by removing unused methods, or by renaming them to a more sensible name. 4. Removing the TestVdsHooks class, as it only tested the removed methods. Change-Id: I1890f429a12cbf7e42727b7360a85ebb1b07b5b0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsHooksById2Query.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsHooksByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vdshooks/VdsHooksParser.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/vdshooks/TestVdsHooks.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHooksListModel.java 8 files changed, 8 insertions(+), 173 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1890f429a12cbf7e42727b7360a85ebb1b07b5b0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: In some locales alerts and Events Icons overlappin...
by alkaplan＠redhat.com 28 Apr '13

28 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: In some locales alerts and Events Icons overlapping on text ...................................................................... webadmin: In some locales alerts and Events Icons overlapping on text On the bottom Alerts/Events pane the "last message" text is overlapped by the icon. The message width changed to 100% to solve it. Change-Id: I403d87ad02f604e8ceb5c5a5e075c03e4fe7cf22 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I403d87ad02f604e8ceb5c5a5e075c03e4fe7cf22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix truncated lined in "New Template" dialog
by rgolan＠redhat.com 28 Apr '13

28 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: webadmin: fix truncated lined in "New Template" dialog ...................................................................... webadmin: fix truncated lined in "New Template" dialog Make the editor width 100% Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=951055 Change-Id: Idea8be2ad3d9e1c812edb9e5c4d126413e67b2a5 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idea8be2ad3d9e1c812edb9e5c4d126413e67b2a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: expand Up/Down buttons for JP locale
by rgolan＠redhat.com 28 Apr '13

28 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: webadmin: expand Up/Down buttons for JP locale ...................................................................... webadmin: expand Up/Down buttons for JP locale this solves line truncation of the button text Bug-Url: http://bugzilla.redhat.com/951040 Change-Id: If0351a831d3e93bb8a024923821267bf5cdc28ff Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0351a831d3e93bb8a024923821267bf5cdc28ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: gluster - subtabs resizable columns
by kmayilsa＠redhat.com 27 Apr '13

27 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: gluster - subtabs resizable columns ...................................................................... webadmin: gluster - subtabs resizable columns Invoking enableColumnResizing() in all gluster related subtabs, and set fixed width for the sub-tab columns. Change-Id: I923951a0370e9bbddac5a014c7900cfafbdb81c2 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java 3 files changed, 16 insertions(+), 10 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I923951a0370e9bbddac5a014c7900cfafbdb81c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0