April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improving memory footprint during audit logging - ea...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint during audit logging - easy one ...................................................................... engine: Improving memory footprint during audit logging - easy one The following variable allocation is unneeded. Improved memory allocation during every get from DB operation Change-Id: I21b4964f278d067aa9daa0b153099b20f348919b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21b4964f278d067aa9daa0b153099b20f348919b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hiding virt related fields in Gluster mode
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: hiding virt related fields in Gluster mode ...................................................................... webadmin: hiding virt related fields in Gluster mode The following ui fields will be hidden when the Application mode is Gluster only. - CPU colum in Cluster main tab - Data Center name in Cluster general tab - Console tab in Host popup - SPM Priority in Host general tab Change-Id: I5352cf678161905d46281331168df4fb7b97b622 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 4 files changed, 16 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5352cf678161905d46281331168df4fb7b97b622 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix unpermitted storage related commands in Audit mode
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix unpermitted storage related commands in Audit mode ...................................................................... core: Fix unpermitted storage related commands in Audit mode When Data Center is in quota enforcement mode 'Audit', a user can perform disk actions on a SD which he does not have permission for (e.g. move disk). This was caused by wrong permission subjects list creation which neglected the 'Audit' mode. Fixed the permission subjects list creation to include 'Audit' mode as well as 'Disabled' mode (in 'Enforcing' mode this operation will be blocked by the quota QuotaManager) Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core+webadmin: Fix aggregate unlimited quota
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core+webadmin: Fix aggregate unlimited quota ...................................................................... core+webadmin: Fix aggregate unlimited quota Unlimited specific quota was not aggregated to unlimited. This was fixed both in QuotaManager and in the WebAdmin. Added a pop-up confirmation window alerting the user that using unlimited specific quota is inadvisable and asking his confirmation. Change-Id: If8f5eb7b2ad1fd5264039ede728c746b0a3cf1b3 Bug-Url: https://bugzilla.redhat.com/923868 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java 4 files changed, 110 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8f5eb7b2ad1fd5264039ede728c746b0a3cf1b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: avoid passing userId in User queries
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: avoid passing userId in User queries ...................................................................... engine: avoid passing userId in User queries Motivation: in the included queries (user queries), a user id is passed in parameters. In user query there is no point in passing userId (it can be taken from session in server side). Removed user id paramerters classes, query base class, related tests, and references both in UI and REST. Note: although there can be a use case for fetching other user vm/pools, it can be revisited upon request (currently there is no use for that). Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDataByUserIDQueriesBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParameters.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParametersTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParametersTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 12 files changed, 16 insertions(+), 216 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding validation for volume name
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding validation for volume name ...................................................................... webadmin: Adding validation for volume name The following validations are added for volume name. - length cannot be more than 50 - name can have only ASCII letters, numbers, '_' or '-' signs Change-Id: I691c7bbaecb764dcc722fd4d9f3fa7be5018a6d2 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691c7bbaecb764dcc722fd4d9f3fa7be5018a6d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: ConcurrentModificationException in AdElementListMo...
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: ConcurrentModificationException in AdElementListModel ...................................................................... frontend: ConcurrentModificationException in AdElementListModel The exception occured in the populateRoles method when user is adding permissions to the VM in permissions subtab. The problem is introduced by refactoring in 05c06da3 and is only visible in gwt-debug console. The problem was caused by removing items from the list in the for-each loop. Fixed by introducing a copy of the modified list (to avoid modifying the collection passed in the argument). Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: noam slomianko <drekmastermind(a)gmail.com> Gerrit-Reviewer: noam slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: recover from corrupted pid file
by juan.hernandez＠redhat.com 02 Apr '13

02 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: recover from corrupted pid file ...................................................................... packaging: engine-service: recover from corrupted pid file The case in which pidfile is empty is common. Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: display N/A for gluster services port if not appli...
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: display N/A for gluster services port if not applicable ...................................................................... webadmin: display N/A for gluster services port if not applicable 'SHD' services may not have port numbers and it will be displayed as 'N/A' if portNo is 0. Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: cleanup: pep8 compliant
by knesenko＠redhat.com 02 Apr '13

02 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: cleanup: pep8 compliant ...................................................................... cleanup: pep8 compliant (cherry picked from commit dd8bb93b7d7217825b5821655eb5e5deeec48b64) Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0