Change in ovirt-engine[master]: webadmin: Consolidated move & copy disk availability checks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Consolidated move & copy disk availability checks
......................................................................
webadmin: Consolidated move & copy disk availability checks
The logic for checking whether moving a disk or copying a disk is allowed
was all the same except for the check whether the disk is used as a
template disk or not, both checks were consolidated to a single check
to avoid …
[View More]redundant checks on the same disks and for better code reuse
Change-Id: Ieb3c388aecc5b007a76c54ed0d41105bc28ebb51
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 27 insertions(+), 40 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb3c388aecc5b007a76c54ed0d41105bc28ebb51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 11 months
Change in ovirt-dwh[master]: etl: rebased to use Talend DI v5.3.0
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: rebased to use Talend DI v5.3.0
......................................................................
etl: rebased to use Talend DI v5.3.0
Change-Id: Ic81fb21f607125d4c0bc13baf3e34e47d2cce6e2
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml
M data-warehouse/history_etl/etl_sources/historyETLProcedure/pom.xml
M data-warehouse/…
[View More]history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_3/AggregationToDaily.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_3/AggregationToHourly.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_3/ConfigurationSync.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_3/DailyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_3/DeleteTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historydelete_3_3/HistoryDelete.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_3/HistoryETL.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hostconfigcheck_3_3/HostConfigCheck.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_3/HourlyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/minimalversioncheck_3_3/MinimalVersionCheck.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_3/ParallelRun.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/samplerunjobs_3_3/SampleRunJobs.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_3/SampleTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/statisticssync_3_3/StatisticsSync.java
M data-warehouse/history_etl/etl_sources/talendRoutines/pom.xml
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/DataOperation.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Mathematical.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Numeric.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Relational.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/StringHandling.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDataGenerator.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDate.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendString.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/AssertCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/BufferedOutput.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/Document.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/FastDateParser.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/FormatterUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/GlobalResource.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/LocaleProvider.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/LogCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/MetterCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/ParserUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/ResumeUtil.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RunStat.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RunTrace.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RuntimeUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/SharedDBConnection.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/StatCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/StringUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TDieException.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TRunJobException.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendDataSource.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThread.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThreadPool.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThreadResult.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendTimestampWithTZ.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TypeConvert.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBConsumer.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBEndpointInfo.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBEndpointRegistry.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBJobInterruptedException.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBProviderCallback.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/TalendESBJob.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/TalendESBJobFactory.java
M data-warehouse/history_etl/tos_project/code/routines/system/DataOperation_0.1.item
M data-warehouse/history_etl/tos_project/code/routines/system/DataOperation_0.1.properties
M data-warehouse/history_etl/tos_project/code/routines/system/StringHandling_0.1.item
M data-warehouse/history_etl/tos_project/code/routines/system/StringHandling_0.1.properties
M data-warehouse/history_etl/tos_project/code/routines/system/TalendDate_0.1.item
M data-warehouse/history_etl/tos_project/code/routines/system/TalendDate_0.1.properties
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.3.item
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.3.properties
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.3.item
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.3.properties
M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.3.item
M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.3.properties
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.3.item
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.3.properties
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.3.item
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.3.properties
M data-warehouse/history_etl/tos_project/process/HistoryDelete_3.3.item
M data-warehouse/history_etl/tos_project/process/HistoryDelete_3.3.properties
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.3.item
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.3.properties
M data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.3.item
M data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.3.properties
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.3.item
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.3.properties
M data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.3.item
M data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.3.properties
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.3.item
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.3.properties
M data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.3.item
M data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.3.properties
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.3.item
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.3.properties
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.3.item
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.3.properties
M data-warehouse/history_etl/tos_project/talend.project
M manifest/ovirt-engine-dwh-manifest.csv
93 files changed, 14,555 insertions(+), 9,131 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic81fb21f607125d4c0bc13baf3e34e47d2cce6e2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: findbugs: adding category ignore list
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: adding category ignore list
......................................................................
findbugs: adding category ignore list
Added a new list in exclude-filters-general.xml.
This list represent categories that we decided not to fix for now or
categories that we do want to attend in the future (mark as TBD)
when running:
$ mvn findbugs:findbugs
will filter the project specific bugs which choose …
[View More]to ignore
when running:
$ mvn findbugs:findbugs -P findbugs-general
will filter project specific as well as the general category list
Change-Id: Idfbc37df07eff4c212cc5210965cabd79a51df36
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
A backend/manager/modules/dal/exclude-filters.xml
M backend/manager/modules/dal/pom.xml
A backend/manager/modules/restapi/interface/common/jaxrs/exclude-filters.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
A backend/manager/modules/restapi/interface/definition/exclude-filters.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/types/pom.xml
A backend/manager/modules/restapi/webapp/exclude-filters.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
A backend/manager/modules/scheduler/exclude-filters.xml
M backend/manager/modules/scheduler/pom.xml
A backend/manager/modules/searchbackend/exclude-filters.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/utils/pom.xml
A backend/manager/modules/vdsbroker/exclude-filters.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/tools/pom.xml
A exclude-filters-general.xml
A frontend/webadmin/modules/frontend/exclude-filters.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
A frontend/webadmin/modules/gwt-extension/exclude-filters.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
33 files changed, 1,082 insertions(+), 215 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfbc37df07eff4c212cc5210965cabd79a51df36
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: core: add the openstack dependency
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add the openstack dependency
......................................................................
core: add the openstack dependency
Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/dependencies/pom.xml
A backend/manager/dependencies/src/main/modules/com/…
[View More]woorea/openstack/sdk/main/module.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M ear/src/main/resources/META-INF/MANIFEST.MF
M packaging/etc/engine-config/engine-config.properties
M pom.xml
7 files changed, 132 insertions(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Disable select quota on edit vm-pool
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Disable select quota on edit vm-pool
......................................................................
webadmin: Disable select quota on edit vm-pool
Quota selection was enabled on edit vm-pool dialog (unlike all other
fields).
set the quota selection box to disabled.
Change-Id: Ifebe28c31bf7f8a5320b70aa62f6eba733333b6c
Bug-Url: https://bugzilla.redhat.com/966003
Signed-off-by: Ofri Masad <omasad(…
[View More]a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifebe28c31bf7f8a5320b70aa62f6eba733333b6c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Added the quota to the Pool-general subtab
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Added the quota to the Pool-general subtab
......................................................................
webadmin: Added the quota to the Pool-general subtab
Added the quota name to the General sub-tab under the Pool main-tab
Change-Id: Ib442572880ef75929eecfc19037cca4ad86f206b
Bug-Url: https://bugzilla.redhat.com/965979
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/…
[View More]modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java
2 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib442572880ef75929eecfc19037cca4ad86f206b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: core: add validation to AddStorageServerConnection
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: add validation to AddStorageServerConnection
......................................................................
core: add validation to AddStorageServerConnection
Prevent addition of a new connection if another one with same
connection details already exists.
Added more unitests for the AddStorageServerConnection command.
Also added VAR__TYPE__STORAGE__CONNECTION to VdcBllMessages, so the connection …
[View More]related
commands will return a proper message with correct entity type (instead
of returning var type storage domain). AppErrors files already contain
this var type, so no need to add it there.
Also, fixed the failure handling of storage domain creation in webadmin UI
- if connection command failed and no connection was
created, there is no need to send command to backend to delete the
connection.
Change-Id: If9bcef8a413589654d36db8d878c844550ae6066
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 129 insertions(+), 37 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9bcef8a413589654d36db8d878c844550ae6066
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: core: Add snapshot validation for empty guid.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add snapshot validation for empty guid.
......................................................................
core: Add snapshot validation for empty guid.
Currently when virt-v2v is used to convert a vm from a foreign
hypervisor (Xen, VMware and etc), it sets the vm_snapshot_id of
all disks of that vm to empty guid.
This later causes issues doing different tasks on snapshots.
The proposed fix is to add a …
[View More]validation whether the
snapshot id is empty and provides an appropriate message.
Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 62 insertions(+), 2 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: core : Automatic logout does not always happen as per UserSe...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core : Automatic logout does not always happen as per UserSessionTimeOutInterval value
......................................................................
core : Automatic logout does not always happen as per UserSessionTimeOutInterval value
After setting UserSessionTimeOutInterval value, automatic logout
does not always happen after the set period for inactivity.
It takes much longer than the time set by the
…
[View More]UserSessionTimeOutInterval parameter.
Change-Id: I4866a28749b0ae1313c07bdbf22779b711892026
Bug-Url: https://bugzilla.redhat.com/953614
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/etc/engine-config/engine-config.properties
4 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4866a28749b0ae1313c07bdbf22779b711892026
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 11 months
Change in ovirt-engine[master]: core: audit log - use hypervisor and not ovirt-node
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: audit log - use hypervisor and not ovirt-node
......................................................................
core: audit log - use hypervisor and not ovirt-node
When adding a hypervisor through the host the manager audit log should
state "Host is hypervisor" and not "Host is ovirt-node" because the term
hypervisor includes both ovirt-node and rhevh.
Change-Id: Ie0dbe402c6c1fa1b5a01af30e4bbb320e12b11d5
…
[View More]Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=921070
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0dbe402c6c1fa1b5a01af30e4bbb320e12b11d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 11 months