October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix a bug when removing iSCSI storage domain
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix a bug when removing iSCSI storage domain ...................................................................... core: Fix a bug when removing iSCSI storage domain Change-Id: I4e027ffed4d896afb5a178bae3b23017afa94cde Bug-Url: https://bugzilla.redhat.com/1156119 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e027ffed4d896afb5a178bae3b23017afa94cde Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix a bug when removing iSCSI storage domain
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix a bug when removing iSCSI storage domain ...................................................................... core: Fix a bug when removing iSCSI storage domain Change-Id: I4e027ffed4d896afb5a178bae3b23017afa94cde Bug-Url: https://bugzilla.redhat.com/1156119 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e027ffed4d896afb5a178bae3b23017afa94cde Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: cleanup in AddVmCommand
by ofrenkel＠redhat.com 26 Oct '14

26 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in AddVmCommand ...................................................................... core: cleanup in AddVmCommand - No need for both tempVar & vmDynamic fields in addVmDynamic method, thus tempVar is removed - Replaced size() > 0 with !isEmpty() - Extract parameters construction for CreateSnapshotFromTemplate command to separate method Change-Id: Idbe9402fc4dd28ac09b014027cc01a880759f360 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 31 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe9402fc4dd28ac09b014027cc01a880759f360 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Store iSCSI Target Address instead of IP Address in DB
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Store iSCSI Target Address instead of IP Address in DB ...................................................................... core: Store iSCSI Target Address instead of IP Address in DB When discovering a new iSCSI target, we send VDSM the address we got from the user's input (which can be an IP address or a DNS name). Since VDSM translates any address to an IP address and sends it back to the engine, we don't want to store this address in the DB, but the original one that we got from the user. Change-Id: Idf6d385606e130f4f529a0b374a9f731310a7f9f Bug-Url: https://bugzilla.redhat.com/1086310 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf6d385606e130f4f529a0b374a9f731310a7f9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64 ...................................................................... osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64 The SLES 11 operating system does not support the rtl8139 network interface, this patch disables it in the osinfo. Change-Id: Ia63250ec01a638e31fcb4b003d5913c0a43f8f36 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151015 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia63250ec01a638e31fcb4b003d5913c0a43f8f36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64 ...................................................................... osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64 The SLES 11 operating system does not support the VirtIO SCSI controller, this patch disables it in the osinfo. Change-Id: I664468106bfb76715db25289fa551436b1086a5c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151010 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I664468106bfb76715db25289fa551436b1086a5c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: osinfo: Enable NIC hotplugging in ppc64
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: osinfo: Enable NIC hotplugging in ppc64 ...................................................................... osinfo: Enable NIC hotplugging in ppc64 This patch enables NIC hotplugging in ppc64 guests, since it is supported in PowerKVM. Change-Id: I755c599c2b93ee901b51572415b95841cb5263c1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154630 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I755c599c2b93ee901b51572415b95841cb5263c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tool: restore excidently removed 'private static final'
by oourfali＠redhat.com 26 Oct '14

26 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: tool: restore excidently removed 'private static final' ...................................................................... tool: restore excidently removed 'private static final' I removed it by mistake[1]. [1] http://gerrit.ovirt.org/#/c/33441/1..2/backend/manager/tools/src/main/java/… Change-Id: Ic51771917e5e8ec22042f2ee6ebdc67af10e2f01 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51771917e5e8ec22042f2ee6ebdc67af10e2f01 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: osinfo: Enable NIC hotplugging in ppc64
by ofrenkel＠redhat.com 26 Oct '14

26 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: osinfo: Enable NIC hotplugging in ppc64 ...................................................................... osinfo: Enable NIC hotplugging in ppc64 This patch enables NIC hotplugging in ppc64 guests, since it is supported in PowerKVM. Change-Id: I755c599c2b93ee901b51572415b95841cb5263c1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154630 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I755c599c2b93ee901b51572415b95841cb5263c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: blank template no need default vm_init
by tnisan＠redhat.com 26 Oct '14

26 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: blank template no need default vm_init ...................................................................... engine: blank template no need default vm_init By having a default vm_init all inherit VMs are getting blank vm_init as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155951 Change-Id: Ifa39cad168d523f1a902095b28cde91bf49f14db Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_1110_remove_vm_init_for_blank_template.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa39cad168d523f1a902095b28cde91bf49f14db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0