Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: spec: otopi-devel is obsolete
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: otopi-devel is obsolete
......................................................................
packaging: spec: otopi-devel is obsolete
updating deps for using the new package otopi-devtools
Change-Id: I07c2f10bee2240486cb08025fd0546a22c1c3b71
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07c2f10bee2240486cb08025fd0546a22c1c3b71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-hosted-engine-setup[master]: packaging: spec: otopi-devel is obsolete
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: otopi-devel is obsolete
......................................................................
packaging: spec: otopi-devel is obsolete
updating deps for using the new package otopi-devtools
Change-Id: I07c2f10bee2240486cb08025fd0546a22c1c3b71
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24146
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07c2f10bee2240486cb08025fd0546a22c1c3b71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: allow attaching iso and export SDs to local DC
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: allow attaching iso and export SDs to local DC
......................................................................
core: allow attaching iso and export SDs to local DC
Attaching an ISO or export domain to local DC
should not be blocked.
Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/24115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core:OnVdsDuringFailureTimer log message malformed
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core:OnVdsDuringFailureTimer log message malformed
......................................................................
core:OnVdsDuringFailureTimer log message malformed
This patch only formats the original message in a more
readable/understandable way.
The typo reported in the bug was fixed in other commit not related to
this bug as part of refine log messaging
Also the Time was removed from the message also in previous work since
this information already exists in each log message
Change-Id: Ibaf1d7c351a2d63d7f3cc58609a9c5016b8a13f5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047567
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaf1d7c351a2d63d7f3cc58609a9c5016b8a13f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered
......................................................................
webadmin: Dialogue for attaching ISOs is not logically ordered
In install host dialog the iso's listed are not
ordered.
Use the new RpmVersionUtils class to order the
iso's in decreasing order of version and release.
Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab
Bug-Url: https://bugzilla.redhat.com/1060636
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Ravi Nori: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Rephrase confusing audit log message
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Rephrase confusing audit log message
......................................................................
engine: Rephrase confusing audit log message
Previous audit log message contained a contradiction. It proposed that
disk was successfully removed but with a storage failure.
Change-Id: I3544d1fde9bb33422175e3212d87c0d190870ff4
Bug-Url: https://bugzilla.redhat.com/1045842
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Sergey Gotliv: Verified
--
To view, visit http://gerrit.ovirt.org/23956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3544d1fde9bb33422175e3212d87c0d190870ff4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: A Burden <aburden(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Move logs out of /usr
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: Move logs out of /usr
......................................................................
packaging: setup: Move logs out of /usr
Move logging of fkvalidator.sh and taskcleaner.sh to the setup log file.
Related-To: https://bugzilla.redhat.com/1030834
Change-Id: I1391b11225e69c98ff843d13db7ef517ec6534b3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/dbutils/fkvalidator.sh
M packaging/setup/dbutils/validatedb.sh
M packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py
4 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/24121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1391b11225e69c98ff843d13db7ef517ec6534b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Move logs out of /usr
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: Move logs out of /usr
......................................................................
packaging: setup: Move logs out of /usr
Move logging of fkvalidator.sh and taskcleaner.sh to the setup log file.
Related-To: https://bugzilla.redhat.com/1030834
Change-Id: I1391b11225e69c98ff843d13db7ef517ec6534b3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/dbutils/fkvalidator.sh
M packaging/setup/dbutils/validatedb.sh
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
4 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/24122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1391b11225e69c98ff843d13db7ef517ec6534b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: Fix disk alias recycling
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix disk alias recycling
......................................................................
webadmin: Fix disk alias recycling
When creating a new disk via webadmin, the suggested disk alias created the
suggested alias from the VM name concated with the amount of the disk on the
VM + 1, in case all disk were created by that convention, deleting a disk
which is not the last one and adding a new disk resulted in a suggested disk
alias which matches the last disk alias exactly
Change-Id: Ie852fbcf26c0742c610631a121b9bfd706c01218
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/1022795
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
2 files changed, 63 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie852fbcf26c0742c610631a121b9bfd706c01218
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Use FixturesTool in VmDAOTest
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Use FixturesTool in VmDAOTest
......................................................................
core: Use FixturesTool in VmDAOTest
Removed local constants and hardcoded values and used FixturesTools
constants instead where those existed. Where they didn't, they were
added.
The fixtures.xml file was also slightly fixed to avoid naming confusion
with non-unique names.
Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
3 files changed, 32 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Allon Mureinik: Verified
Omer Frenkel: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months