Change in ovirt-dwh[master]: packaging: setup: Do not fail on errors while restoring perm...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: Do not fail on errors while restoring permissions
......................................................................
packaging: setup: Do not fail on errors while restoring permissions
Bug-Url: https://bugzilla.redhat.com/1073471
Change-Id: I5368388764576a2900a772b82f84d0b366f106c7
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/dbscripts/dbfunc-base.sh
M packaging/dbscripts/dbfunc-common.sh
2 files changed, 22 insertions(+), 5 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5368388764576a2900a772b82f84d0b366f106c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: display principal name post authn
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: display principal name post authn
......................................................................
aaa: display principal name post authn
post authn there is no sense to display the user that user entered, as
the principal name that is used is completely different.
Topic: AAA
Change-Id: Ibb0f7dd07d71cbcfc361f9da3d5ad677c5fb090b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb0f7dd07d71cbcfc361f9da3d5ad677c5fb090b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: packaging: dbscripts: Do not fail on errors while restoring ...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: dbscripts: Do not fail on errors while restoring permissions
......................................................................
packaging: dbscripts: Do not fail on errors while restoring permissions
Change-Id: I6c266617138dab641be7a06b146b9ceb57590340
Bug-Url: https://bugzilla.redhat.com/1073471
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/dbscripts/dbfunc-base.sh
M packaging/dbscripts/dbfunc-common.sh
2 files changed, 22 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27907
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c266617138dab641be7a06b146b9ceb57590340
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Fix potential NPE when in CheckboxColumn
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Fix potential NPE when in CheckboxColumn
......................................................................
webadmin: Fix potential NPE when in CheckboxColumn
getValue(object)) in checkboxColumn.render() might return null, resulting in
an NPE when used in if. Fix the if to handle null.
Note: this bug could only occur if a checkboxColumn is not editable
*and* it's value is null.
Change-Id: I26f688984083fbd6964972e79e50960b254c547b
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1097754
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/27726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: removing lock from DetachStorageDomainFromPoolCommand
by laravot@redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: removing lock from DetachStorageDomainFromPoolCommand
......................................................................
core: removing lock from DetachStorageDomainFromPoolCommand
The lock on the domain id when detaching it was added in change
I4ee8cd4b64393d195fe45349f49996e45ce09f0f but it's currently incorrect
because the detach command is also executed from commands that already
take the lock on the storage domain, which will lead to a failure.
We need to pass the command context to avoid that situation, but that
will be inspected in a further patch - right now this patch returns the
situation to it's previous state.
Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Liron Ar: Verified
--
To view, visit http://gerrit.ovirt.org/27938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: engine: Fix typo in message
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Fix typo in message
......................................................................
engine: Fix typo in message
Change-Id: Ic7b7be69c0207ca61b476f0eeacf73867673fd6f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/27931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b7be69c0207ca61b476f0eeacf73867673fd6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in mom[master]: Adding support in CPU monitoring
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: Adding support in CPU monitoring
......................................................................
Adding support in CPU monitoring
Adding two new collectors and a controller to enable
monitoring the CPU tuning parameters: vcpu_quota, vcpu_period.
This patch is part of the CPU SLA feature: http://www.ovirt.org/Features/CPU_SLA.
Changes in collectors:
Added a new utility method to Collector.py, "count_int",
count the number of matches in a string according to a regular expression.
Added HostCpu to expose the number of cpu on the host.
Added GuestCpuTune to expose the current tuning parameters and the latest user selection
Changes in controller:
Added CpuTune to apply changes to the vcpu tuning.
This patch is used in the cputune.policy, some code snip:
(defvar anchor 100000)
(def check_and_set_quota (guest)
{
(defvar calcQuota (/ (* anchor (/ guest.user_vcpu_limit 100))) guest.vcpu_count)
(if (!= guest.vcpu_quota calcQuota)
(guest.Control "vcpu_quota" calcQuota) 0)
})
Change-Id: I31428499ae7b34cafa3eacf5ca0d7a39eabe23ec
Signed-off-by: Kobi Ianko <kianku(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27240
Tested-by: Kobi Ianko <kobi(a)redhat.com>
Reviewed-by: Adam Litke <alitke(a)redhat.com>
---
M mom/Collectors/Collector.py
A mom/Collectors/GuestCpuTune.py
A mom/Collectors/HostCpu.py
A mom/Controllers/CpuTune.py
M mom/HypervisorInterfaces/libvirtInterface.py
M mom/HypervisorInterfaces/vdsmInterface.py
6 files changed, 225 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Looks good to me, approved
Kobi Ianko: Verified
--
To view, visit http://gerrit.ovirt.org/27240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31428499ae7b34cafa3eacf5ca0d7a39eabe23ec
Gerrit-PatchSet: 12
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: dr2 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr2 report - added comments to queries
......................................................................
reports: dr2 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I7435ab09c14b50a4f24f8016b0829a4b76ca822c
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7435ab09c14b50a4f24f8016b0829a4b76ca822c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: dr1 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr1 report - added comments to queries
......................................................................
reports: dr1 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I5d4e1d8f184fabe08e1adbc1f74b8803bcd2fe03
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/jrxmls/system_entities_counts_list_dr1_jrxml.data
1 file changed, 41 insertions(+), 25 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d4e1d8f184fabe08e1adbc1f74b8803bcd2fe03
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: dr18 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr18 report - added comments to queries
......................................................................
reports: dr18 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I3193e16cd226a91e4f44084555763c48b3360100
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
1 file changed, 83 insertions(+), 15 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3193e16cd226a91e4f44084555763c48b3360100
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months