Change in ovirt-engine[master]: webadmin: Password field is not validate on host install
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Password field is not validate on host install
......................................................................
webadmin: Password field is not validate on host install
When the host is reinstalled and the password is
choosen as authntication mechanism, empty password
should display an error.
If the user is on Network tab the general tab is selected
and the field is highlighted in red indicating that
it can't be empty.
Change-Id: I3745852a0b1b33e5ba04583e911bbbc90fd8d796
Bug-Url: https://bugzilla.redhat.com/1086798
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml
4 files changed, 45 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Gilad Chaplik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3745852a0b1b33e5ba04583e911bbbc90fd8d796
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Adding a down event for HA Reservation
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Adding a down event for HA Reservation
......................................................................
engine: Adding a down event for HA Reservation
Adding a down event to HA Reservation, this event will be triggered
only in case the current status of the Cluster was changed from not HA safe to HA safe.
This is done to ensure that the user is notified that his action
(freeing resources) have made the Cluster HA safe.
Change-Id: Iebc82d3cc190d439b77e45e7e6b3eb7451f71c3c
Bug-Url: https://bugzilla.redhat.com/1076211
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
6 files changed, 27 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Kobi Ianko: Verified
--
To view, visit http://gerrit.ovirt.org/27471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebc82d3cc190d439b77e45e7e6b3eb7451f71c3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: prepare upgrade to apache-sshd 0.11.0
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: host-deploy: prepare upgrade to apache-sshd 0.11.0
......................................................................
host-deploy: prepare upgrade to apache-sshd 0.11.0
since 3.1 we use internal implementation of KeyPairProvider which was
changed in future releases, in order to make transition easier drop the
internal implementation in favour of super interface.
required subset of I6943590f1c without implications.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1094123
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1093882
Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java
1 file changed, 19 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4.1]: backend: upgrade - process symbolic link files
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: backend: upgrade - process symbolic link files
......................................................................
backend: upgrade - process symbolic link files
Currently if users decided to upgrade the ovirt-node via restapi using
the symbolic link name ovirt-node-iso.iso it will fail. This patch adds
getCanonicalPath() call to resolves the symbolic links.
Change-Id: If4084095c40848dc5573d434c1c7ca497883b280
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093303
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 22 insertions(+), 9 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27467
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4084095c40848dc5573d434c1c7ca497883b280
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: dwh: Update minimal ETL version
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: dwh: Update minimal ETL version
......................................................................
dwh: Update minimal ETL version
Needed following http://gerrit.ovirt.org/26992
Change-Id: I5757f1d349fad82cd7f5b3371814a725fb443e0e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yaniv Dary: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5757f1d349fad82cd7f5b3371814a725fb443e0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Don't resurrect removed bonds for label
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Don't resurrect removed bonds for label
......................................................................
engine: Don't resurrect removed bonds for label
If a network was attached via label to a bond being removed, the
operation would still be blocked by the CanDoAction, this is now
fixed.
Change-Id: Ie5c0648999a80c313f6565673e7880a2b34f3e53
Bug-Url: https://bugzilla.redhat.com/1084771
Bug-Url: https://bugzilla.redhat.com/1084915
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
(cherry picked from commit 433fa09c87eb88d6d5e187f25d7a2dd1e9cb4c35)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5c0648999a80c313f6565673e7880a2b34f3e53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Predetermine volume type on copy according to the dest...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Predetermine volume type on copy according to the destination domain
......................................................................
core: Predetermine volume type on copy according to the destination domain
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1084789
Change-Id: I75f58d73e95a73bf7d74f318dbd95cd838a74e98
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75f58d73e95a73bf7d74f318dbd95cd838a74e98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: nit: pep8 fixes
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nit: pep8 fixes
......................................................................
nit: pep8 fixes
Change-Id: I1e1b39482b6c94150a69bada02cd80d95505a3ae
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
M src/sos/plugins/engine.py
M src/sos/plugins/ovirt_engine_dwh.py
M src/sos/plugins/ovirt_engine_reports.py
4 files changed, 39 insertions(+), 39 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e1b39482b6c94150a69bada02cd80d95505a3ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-log-collector[master]: nit: pep8 fixes
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nit: pep8 fixes
......................................................................
nit: pep8 fixes
Change-Id: I50422e63f6840e4ea8ec40259f98ffb897f64ede
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50422e63f6840e4ea8ec40259f98ffb897f64ede
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: nit: pep8 fixes
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nit: pep8 fixes
......................................................................
nit: pep8 fixes
Change-Id: I50422e63f6840e4ea8ec40259f98ffb897f64ede
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50422e63f6840e4ea8ec40259f98ffb897f64ede
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months