Change in ovirt-engine[master]: engine: Adjust NetworkUtils to accept any vlan device name -...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust NetworkUtils to accept any vlan device name - phase 2
......................................................................
engine: Adjust NetworkUtils to accept any vlan device name - phase 2
This patch contains-
1. Removing from all the old methods assuming vlan device name format is
baseNic.vlanId from NetworkUtils.
2. Fixing NetworkUtilsTest.
The patch is the last one in a chain of patches.
The previous patches fixed all the places thats used the old methods.
Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
2 files changed, 17 insertions(+), 75 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/27153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: refactoring NetworkUtils.getVlanDeviceName
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: refactoring NetworkUtils.getVlanDeviceName
......................................................................
engine: refactoring NetworkUtils.getVlanDeviceName
This patch changes the method name to constructVlanDeviceName.
The method should be used only for constructing new vlan devices.
Other places shoulded assume the vlan device name is in format-
baseIface.vlanId
Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/27152
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust NetworkMonitoringHelper to accept any vlan de...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust NetworkMonitoringHelper to accept any vlan device name
......................................................................
engine: Adjust NetworkMonitoringHelper to accept any vlan device name
Changes done in this patch-
1. Using iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. Using the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I96c998b8575bc8d48ec482d725de3579f51a7c88
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java
1 file changed, 6 insertions(+), 27 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/27151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96c998b8575bc8d48ec482d725de3579f51a7c88
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust GetVlanParentQuery to accept any vlan device ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust GetVlanParentQuery to accept any vlan device name
......................................................................
engine: Adjust GetVlanParentQuery to accept any vlan device name
Changes done in this patch-
1. Using iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. Using the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I15fc7bb0c198fb5ff67701399ee523057e337370
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/27150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15fc7bb0c198fb5ff67701399ee523057e337370
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust VdsUpdateRunTimeInfo to accept any vlan devic...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust VdsUpdateRunTimeInfo to accept any vlan device name
......................................................................
engine: Adjust VdsUpdateRunTimeInfo to accept any vlan device name
Changes done in this patch-
1. Using iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. Using the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I57b89a8401782200a608be67da5ffd32c6590275
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/26618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57b89a8401782200a608be67da5ffd32c6590275
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept any vlan device name
......................................................................
engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept any vlan device name
Changes done in the command-
1. The command uses iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. The command uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I8f003a2889ca429b6158889bc2f3335d111c9192
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/26617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f003a2889ca429b6158889bc2f3335d111c9192
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust SetupNetworks to accept any vlan device name
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust SetupNetworks to accept any vlan device name
......................................................................
engine: Adjust SetupNetworks to accept any vlan device name
Changes done in this patch-
1. SetupNetworks uses iface.getBaseInterface() and iface.getVlanId()
instead of determining this values from the vlan device name (since its
format is no longer- baseIface.vlanId).
2. SetupNetworks uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
4 files changed, 47 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust RemoveBondCommand to accept any vlan device name
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust RemoveBondCommand to accept any vlan device name
......................................................................
engine: Adjust RemoveBondCommand to accept any vlan device name
Changes done in the command-
1. The command uses iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. The command uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: Iaaa99b53249a56a3870bf6c812fa9ae618d09787
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa99b53249a56a3870bf6c812fa9ae618d09787
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust LabelNicCommand to accept any vlan device name
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust LabelNicCommand to accept any vlan device name
......................................................................
engine: Adjust LabelNicCommand to accept any vlan device name
Changes done in the command-
1. The command uses iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. The command uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I396ab046280c22cd98d77fc38bf7e942de156667
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I396ab046280c22cd98d77fc38bf7e942de156667
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Adjust GetAllSiblingVlanInterfacesQuery to accept an...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust GetAllSiblingVlanInterfacesQuery to accept any vlan name
......................................................................
engine: Adjust GetAllSiblingVlanInterfacesQuery to accept any vlan name
Changes done in the command-
1. The query uses iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. The query uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: I95a20887f8359bab66ea54747d21e05c310fc21c
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/26613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95a20887f8359bab66ea54747d21e05c310fc21c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years