May 2014 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Fixed issue with non-existing config option
by dcaroest＠redhat.com 05 May '14

05 May '14

David Caro has submitted this change and it was merged. Change subject: Fixed issue with non-existing config option ...................................................................... Fixed issue with non-existing config option When using a mock configuration wothout yum.conf option, it will fail on missing key. Change-Id: Ie7d79734dfb8da64dc1518e8fab4c9a10a2f9f39 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_genconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7d79734dfb8da64dc1518e8fab4c9a10a2f9f39 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>

1 0

Change in ovirt-engine[master]: frontend: Always assume GuestAgent to be present for SSO req...
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Always assume GuestAgent to be present for SSO requests ...................................................................... frontend: Always assume GuestAgent to be present for SSO requests Motivation: There are already so many different names for the guest agent and their versions that it is an impossible task for the engine to maintain that. And it's unreliable for such cases. Besides that, it doesn't tell the engine anyway if there's SSO support or not. Using the application list to identify the guest agent version is not a good idea. Instead we'll check in VDSM whether or not the guest agent is there, since it gets a heartbeat it'll know early enough if it is responsive and only then forward the desktopLogin request. http://gerrit.ovirt.org/27147 Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vinzenz Feenstra: Verified Frank Kobzik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: setup: Do not check jasper home existance
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not check jasper home existance ...................................................................... packaging: setup: Do not check jasper home existance as it might not exist - we want to allow: $ yum install ovirt-engine ovirt-engine-reports-setup $ engine-setup and have jasperreports installed by setup. Keep the check for developer mode. Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Bug-Url: https://bugzilla.redhat.com/1093360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit cb9f81c828a591293c67eedc930c6b968adfbb96) --- M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Do not check jasper home existance
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not check jasper home existance ...................................................................... packaging: setup: Do not check jasper home existance as it might not exist - we want to allow: $ yum install ovirt-engine ovirt-engine-reports-setup $ engine-setup and have jasperreports installed by setup. Keep the check for developer mode. Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Bug-Url: https://bugzilla.redhat.com/1093360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: Add host# and vm# to cluster tab
by emesika＠redhat.com 05 May '14

05 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core, webadmin: Add host# and vm# to cluster tab ...................................................................... core, webadmin: Add host# and vm# to cluster tab In webadmin add an ability to see the count of VMs and Hosts for a cluster Change-Id: I9935c67db2a88960cd721aec4bfd71e70c9b4f57 Bug-Url: https://bugzilla.redhat.com/1084120 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroupHostsAndVMs.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M packaging/dbscripts/vds_groups_sp.sql 9 files changed, 162 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9935c67db2a88960cd721aec4bfd71e70c9b4f57 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Batch updates might create a database deadlock
by yzaslavs＠redhat.com 05 May '14

05 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Batch updates might create a database deadlock ...................................................................... core: Batch updates might create a database deadlock Batch updates might create a database deadlock in systems under load Sorting the batch collection by id should solve this problem Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Bug-Url: https://bugzilla.redhat.com/1092299 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate Step Enum (#1092448)
by oliel＠redhat.com 05 May '14

05 May '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Validate Step Enum (#1092448) ...................................................................... restapi: Validate Step Enum (#1092448) Up until now, if user supplied invalid step-type, the server would fail. This patch adds a validation that the step-type is valid Bug-Url: http://bugzilla.redhat.com/1092448 Change-Id: I7768fb15b0f9c5924cab0f4e2238cf49d21eb655 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StepValidator.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7768fb15b0f9c5924cab0f4e2238cf49d21eb655 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand
by masayag＠redhat.com 05 May '14

05 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand ...................................................................... engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand Add check if engineDisplayNetwork is not null prior accessing its name. Change-Id: I854e51346c01eb57d424a342d13754e17f32f221 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/27371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854e51346c01eb57d424a342d13754e17f32f221 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: setup: Removing build-conf files on failure
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Removing build-conf files on failure ...................................................................... packaging: setup: Removing build-conf files on failure If setup fails it should cleanup the partially deployed files in order to allow a future clean setup. If those files were already there it restores the backup copy of the older ones, otherwise it simply removes the new files. Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Bug-Url: https://bugzilla.redhat.com/1091700 Bug-Url: https://bugzilla.redhat.com/1084749 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 5c99c747baa3013f60bd1d2dd77cc316ccae7c2c) --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Removing build-conf files on failure
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Removing build-conf files on failure ...................................................................... packaging: setup: Removing build-conf files on failure If setup fails it should cleanup the partially deployed files in order to allow a future clean setup. If those files were already there it restores the backup copy of the older ones, otherwise it simply removes the new files. Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Bug-Url: https://bugzilla.redhat.com/1091700 Bug-Url: https://bugzilla.redhat.com/1084749 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 18 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0