July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Adding some ctors tests.
by yzaslavs＠redhat.com 27 Jul '14

27 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding some ctors tests. ...................................................................... core: Adding some ctors tests. Change-Id: Iea6593f19871e241d19bb6265cb48ffe03ea2eb3 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea6593f19871e241d19bb6265cb48ffe03ea2eb3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RngDeviceCommand fixes
by yzaslavs＠redhat.com 27 Jul '14

27 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: RngDeviceCommand fixes ...................................................................... core: RngDeviceCommand fixes the class is a conctrete class, No reason for its CTORs not to be public Change-Id: Ie789c93d918274370aa1007ff838f3d0071b1b60 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRngDeviceCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie789c93d918274370aa1007ff838f3d0071b1b60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding context ctor ProcessOvfUpdateForStorageDomain
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Adding context ctor ProcessOvfUpdateForStorageDomain ...................................................................... core: Adding context ctor ProcessOvfUpdateForStorageDomain Change-Id: Ia170d17191b3fd541fa4b0d695a94e3ed06dee72 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia170d17191b3fd541fa4b0d695a94e3ed06dee72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Wrong vnic profiles on vm based on template from ano...
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Wrong vnic profiles on vm based on template from another cluster ...................................................................... engine: Wrong vnic profiles on vm based on template from another cluster If- 1. New vm is based on template from different cluster (or even dc in case of 'Blank' template). And 2. The template has nics which's profile's network is not attached to the vm's cluster. Then- The profiles on the vm's nics should be overridden by 'Empty' profiles. Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Throw canDo on addVmCommand if template is not in cl...
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Throw canDo on addVmCommand if template is not in cluster ...................................................................... engine: Throw canDo on addVmCommand if template is not in cluster added a canDo- 'VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_NOT_EXISTS_IN_CURRENT_DC' to- AddVmCommand- if the templates is not in the vm's dc. AddVmFromScratchCommand- if the templates is not in the vm's dc and not 'Blank'. Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 22 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: GetRngDeviceQuery should be a user query
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: GetRngDeviceQuery should be a user query ...................................................................... core: GetRngDeviceQuery should be a user query Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Bug-Url: https://bugzilla.redhat.com/1122427 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRngDeviceQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Minor adjustment for remove external network message
by masayag＠redhat.com 27 Jul '14

27 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Minor adjustment for remove external network message ...................................................................... webadmin: Minor adjustment for remove external network message Change-Id: If65a2cf50bb89b29988913fd8801b4ce32ef6e95 Bug-Url: https://bugzilla.redhat.com/1101068 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65a2cf50bb89b29988913fd8801b4ce32ef6e95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: More accurate wording for IntegerValidation
by lvernia＠redhat.com 27 Jul '14

27 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: More accurate wording for IntegerValidation ...................................................................... webadmin: More accurate wording for IntegerValidation The validation actually checks whether a number is lesser/greater than OR equals minimum/maximum limits. Change-Id: I553a53d40116c577cc97e43e3b6db2791bd0ab5e Bug-Url: https://bugzilla.redhat.com/1115062 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I553a53d40116c577cc97e43e3b6db2791bd0ab5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: Revert "reports: provide reports.xml to engine over http"
by ydary＠redhat.com 27 Jul '14

27 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: Revert "reports: provide reports.xml to engine over http" ...................................................................... Revert "reports: provide reports.xml to engine over http" This reverts commit 1cef17b7217494e1a90a374d749ab09f651f86d6. Change-Id: I8736651ea01f72d3ae11de404ae81bef76924b27 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8736651ea01f72d3ae11de404ae81bef76924b27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: provide reports.xml to engine over http
by ydary＠redhat.com 27 Jul '14

27 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: provide reports.xml to engine over http ...................................................................... reports: provide reports.xml to engine over http this is to support reports integration to webadmin on separate servers. Change-Id: Ia0230c58de2edfb3896b7af2e71ad27d47ee2229 Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0230c58de2edfb3896b7af2e71ad27d47ee2229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0