July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Render Providers main tab columns sortable
by lvernia＠redhat.com 10 Jul '14

10 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Render Providers main tab columns sortable ...................................................................... webadmin: Render Providers main tab columns sortable Rendered columns sortable via server-side sorting. Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Render Networks main tab columns sortable
by lvernia＠redhat.com 10 Jul '14

10 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Render Networks main tab columns sortable ...................................................................... webadmin: Render Networks main tab columns sortable Rendered all columns sortable except for: * Comment isn't helpful when it's displayed as icon. * Role and Provider, don't currently support server-side sorting. Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 3 files changed, 22 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Implement permission sorting by role icon
by lvernia＠redhat.com 10 Jul '14

10 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Implement permission sorting by role icon ...................................................................... webadmin: Implement permission sorting by role icon Implemented sorting for permission subtabs according to the role icon (ordinary user is lesser than administrator). Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: setup: test only config file db password
by ydary＠redhat.com 10 Jul '14

10 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: test only config file db password ...................................................................... packaging: setup: test only config file db password Testing also env breaks unattended clean setup. Bug-Url: https://bugzilla.redhat.com/1094016 Bug-Url: https://bugzilla.redhat.com/1100281 Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: test only config file db password
by ydary＠redhat.com 10 Jul '14

10 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: test only config file db password ...................................................................... packaging: setup: test only config file db password Testing also env breaks unattended clean setup. Bug-Url: https://bugzilla.redhat.com/1094016 Bug-Url: https://bugzilla.redhat.com/1100281 Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 10 Jul '14

10 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 0849d86, tag ovirt-engine-3.4.3_rc. Change-Id: I4d8b6e57404a5abaad12384dd1a4f788cee2db2d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 26 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d8b6e57404a5abaad12384dd1a4f788cee2db2d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Enable RESTAPI CSRF protection
by juan.hernandez＠redhat.com 10 Jul '14

10 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Enable RESTAPI CSRF protection ...................................................................... webadmin: Enable RESTAPI CSRF protection This patch changes the webadmin application so that it will always request CSRF protection when creating RESTAPI sessions. Change-Id: I92c41f18bcbb90441f352444dcc78408e8e61b16 Related: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92c41f18bcbb90441f352444dcc78408e8e61b16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: CSRF protection filter
by juan.hernandez＠redhat.com 10 Jul '14

10 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: CSRF protection filter ...................................................................... restapi: CSRF protection filter This patch introduces a filter that protects the RESTAPI from CSRF attacks. Protection is enabled/disabled globally, using the new CSRFProtection configuration parameter. By default this parameter is "false", so the protection isn't enabled. This can be changed with the "engine-config" tool, as follows: # engine-config -s CSRFProtection=true If the protection is enabled globally, then the caller can enable for a particular session using the "csrf-protection" preference: GET /ovirt-engine/api HTTP/1.1 Authorization: Basic P/c1qcSSGuTlxUCTEUCosZfZ Host: ovirt.example.com Prefer: persistent-auth, csrf-protection If this preference isn't specified then the session won't be protected, even if it is enabled globally. For protected sessions the caller must always include the "JSESSIONID" header, which should contain the value of the session identifier: GET /ovirt-engine/api HTTP/1.1 Cookie: JSESSIONID=y+FXYivGm2rdajrNhTRatNjl Prefer: persistent-auth, csrf-protection JSESSIONID: y+FXYivGm2rdajrNhTRatNjl If the protection is enabled and the caller fails to send this token then the request will be rejected and logged. Change-Id: I5700192b62e514091c9f29910596f312c068c5b2 Bug-Url: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml A backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/CSRFProtectionFilter.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/modules/org/ovirt/engine/api/interface-common-jaxrs/main/module.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 8 files changed, 243 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5700192b62e514091c9f29910596f312c068c5b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Parse Prefer according to RFC 7240
by juan.hernandez＠redhat.com 10 Jul '14

10 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Parse Prefer according to RFC 7240 ...................................................................... core: Parse Prefer according to RFC 7240 Currently we assume that the "Prefer" header contains only the value "persistent-auth" and we check it directly. This prevents using the header for other purposes, like including several preferences in the same header, as described in RFC 7240. This will be required by later patches, in particular for the patches implementing CSRF protection in the RESTAPI. This patch changes the engine so that it parses correctly the hader, according to the RFC, using the Apache HttpComponents library. A module for this library is already provided by the application server. Change-Id: I917aa9e56a50a0a3f85447003676ffd59752749d Related: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/aaa/pom.xml M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml A backend/manager/modules/aaa/src/test/java/org/ovirt/engine/core/aaa/filters/FiltersHelperTest.java M pom.xml 5 files changed, 139 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917aa9e56a50a0a3f85447003676ffd59752749d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: do not use /var/tmp for reportsd
by ydary＠redhat.com 10 Jul '14

10 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: do not use /var/tmp for reportsd ...................................................................... packaging: do not use /var/tmp for reportsd /var/tmp is intended for temporary files. reportsd is a long-running process, and should not keep its files there. Use /var/lib/ovirt-engine-reports/jboss_runtime instead. This is an adaptation of I88563c8c0d319eb3356b47233a31c82d9e8b84c7 which was for the ovirt engine service. Change-Id: Icc5c730d8944ec686f6025dbacc6cc5118c9b180 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M Makefile M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.conf.in M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.xml.in 4 files changed, 15 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5c730d8944ec686f6025dbacc6cc5118c9b180 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0