July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: upload: remove nossl option
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: remove nossl option ...................................................................... upload: remove nossl option Rest APIs doesn't support plain http connection so nossl doesn't make sense. Removing it. Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Bug-Url: https://bugzilla.redhat.com/1100825 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 2619a581f6c0e00688a1d49618f28b53da83b884) --- M src/__main__.py 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[master]: upload: remove nossl option
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: remove nossl option ...................................................................... upload: remove nossl option Rest APIs doesn't support plain http connection so nossl doesn't make sense. Removing it. Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Bug-Url: https://bugzilla.redhat.com/1100825 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: Missing hostId parameter on reconstructMaster
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Missing hostId parameter on reconstructMaster ...................................................................... jsonrpc: Missing hostId parameter on reconstructMaster Vdsm json schema was not consistent with vdsm api and there was missing hostId parameter. Change-Id: Ibe40b9f054278a7ffe108efb0e2c5a60bf643b64 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1115466 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Federico Simoncelli: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe40b9f054278a7ffe108efb0e2c5a60bf643b64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: remove PatternFly from source tree
by awels＠redhat.com 08 Jul '14

08 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: remove PatternFly from source tree ...................................................................... userportal, webadmin: remove PatternFly from source tree *NOTE:* after this commit, developers must install the PatternFly RPM dependency, or the web UI will be severely broken. Remove PatternFly dependency from source tree. Symlink ovirt.brand to PatternFly installation at /usr/share/patternfly1/resources. Create patternfly-ovirt.css that contains ovirt's customizations of PatternFly classes. Change-Id: I1da6bece78951a98be148050078c6d8201018273 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile M README.branding M README.developer M ovirt-engine.spec.in M packaging/branding/ovirt.brand/common.css D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.eot D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.svg D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.ttf D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.woff D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.eot D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.svg D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.ttf D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.woff D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.eot D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.svg D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.ttf D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.woff D packaging/branding/ovirt.brand/js/patternfly.min.js A packaging/branding/ovirt.brand/patternfly-ovirt.css 59 files changed, 170 insertions(+), 2,139 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/29018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1da6bece78951a98be148050078c6d8201018273 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Ignore errors when cleaning old connection
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Ignore errors when cleaning old connection ...................................................................... codegen: Ignore errors when cleaning old connection The constructor of the API object tries to clean connections left around by the user, calling their "disconnect" method. If this fails the creation of the new API object fails as well. To avoid that this patch changes the SDK so that any error during that cleaup is ignored. Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Bug-Url: https://bugzilla.redhat.com/1116009 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 3b6ed1ed646eb57eadacc59e0e66cfa56d4547b2) --- M src/codegen/templates/entrypointtemplate 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Ignore errors when cleaning old connection
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Ignore errors when cleaning old connection ...................................................................... codegen: Ignore errors when cleaning old connection The constructor of the API object tries to clean connections left around by the user, calling their "disconnect" method. If this fails the creation of the new API object fails as well. To avoid that this patch changes the SDK so that any error during that cleaup is ignored. Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Bug-Url: https://bugzilla.redhat.com/1116009 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/templates/entrypointtemplate 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: fix filter/weight/balance getter
by gchaplik＠redhat.com 08 Jul '14

08 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: fix filter/weight/balance getter ...................................................................... restapi: fix filter/weight/balance getter fixes both get and remove policy units per scheduling policy. Change-Id: I0a336e9fe3f8fa77d94469d28ecad64234e9b685 Bug-Url: https://bugzilla.redhat.com/1114944 Bug-Url: https://bugzilla.redhat.com/1115071 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBalanceResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBalancesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFiltersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPolicyUnitResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPolicyUnitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWeightResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWeightsResource.java 8 files changed, 45 insertions(+), 14 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/29514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a336e9fe3f8fa77d94469d28ecad64234e9b685 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: impossible to delete scheduling policy
by gchaplik＠redhat.com 08 Jul '14

08 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: impossible to delete scheduling policy ...................................................................... restapi: impossible to delete scheduling policy Change-Id: I36b14ca91aaa0aa862b42fd598b9831f6a7b3893 Bug-Url: https://bugzilla.redhat.com/1114926 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SchedulingPoliciesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPoliciesResource.java 2 files changed, 20 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/29513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36b14ca91aaa0aa862b42fd598b9831f6a7b3893 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: add repo for PatternFly
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: add repo for PatternFly ...................................................................... packaging: add repo for PatternFly Change-Id: I5ce5b58e3fd5a7f3377d35cc6965b04f8b3c2c91 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M ovirt-release-3.5/Makefile.am M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-el-deps.repo.in M ovirt-release-3.5/ovirt-f19-deps.repo.in A ovirt-release-3.5/ovirt-f20-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in 6 files changed, 31 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ce5b58e3fd5a7f3377d35cc6965b04f8b3c2c91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix NPE in ConsoleProtocol
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Fix NPE in ConsoleProtocol ...................................................................... frontend: Fix NPE in ConsoleProtocol This patch fixes NPE when changing VM console protocol. The exception was caused by modifying collection that was created using Arrays.asList() and this list implementation throws NPE when removing elements from it. Fixed by wrapping the list in ArrayList implementation, so that client code can mutate the collection. Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1109376 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0