Change in ovirt-engine[master]: userportal, webadmin: remove FF17, add FF31 to supported bro...
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported browsers
......................................................................
userportal, webadmin: remove FF17, add FF31 to supported browsers
Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6
Bug-Url: https://bugzilla.redhat.com/1043430
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Einav Cohen: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/33280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in samples-uiplugins[master]: gluster-nagios-monitoring: fixing extra login popup from tre...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: gluster-nagios-monitoring: fixing extra login popup from trends tab.
......................................................................
gluster-nagios-monitoring: fixing extra login popup from trends tab.
gluster-nagios-monitoring UI plugin is using legacy http://host:/api
URL for Rest API calls and thats the reason for extra additional popup
in the trends tab.
Changing the URL to to use /ovirt-engine/api also sending the
"Prefer:persistent-auth" header with all Rest API calls to keep
the wedamin's Rest API session active.
Change-Id: I4dba4af5cef01a5d30ed24831bd2333ba9ae05bd
Bug-Url: https://bugzilla.redhat.com/1143041
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M gluster-nagios-monitoring/src/js/services.js
1 file changed, 12 insertions(+), 7 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, but someone else must approve
Vojtech Szocs: Verified; Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/33060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dba4af5cef01a5d30ed24831bd2333ba9ae05bd
Gerrit-PatchSet: 3
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[master]: core: Fixed missing type variable in disk profiles
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fixed missing type variable in disk profiles
......................................................................
core: Fixed missing type variable in disk profiles
Fixed the missing type variable in disk profiles.
Also, fixed the bug for CPU profiles, since it share
the same common base class as disk profile.
Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58
Bug-Url: https://bugzilla.redhat.com/1142887
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveCpuProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateProfileCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
14 files changed, 41 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: core: adding RetrieveImageDataCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding RetrieveImageDataCommand
......................................................................
core: adding RetrieveImageDataCommand
This patch adds RetrieveImageDataCommand and changes
AttachStorageDomainToPoolCommand to use it instead of executing the
vds command directly. This is done so that the needed CDA checks/locks
will be taken. Furthermore, this patch takes care of polling the created
upload task on vdsm side.
Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e
Bug-Url: https://bugzilla.redhat.com/1136840
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 75 insertions(+), 7 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: AsyncTaskType - uploadImageFromStream to uploadImageTo...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: AsyncTaskType - uploadImageFromStream to uploadImageToStream
......................................................................
core: AsyncTaskType - uploadImageFromStream to uploadImageToStream
changed uploadImageFromStream to uploadImageToStream as appears on vdsm.
Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8
Bug-Url: https://bugzilla.redhat.com/1136840
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: introducing ImageSpmCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: introducing ImageSpmCommand
......................................................................
core: introducing ImageSpmCommand
This patch extracts ImageSpmCommand as a parent class of UploadStreamCommand to
contain shared logic between this command and the to-be-added
RetrieveImageDataCommand.
Change-Id: I32166ee993bce33680f6b2feb5359666e414c777
Bug-Url: https://bugzilla.redhat.com/1136840
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UploadStreamCommand.java
2 files changed, 135 insertions(+), 103 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32166ee993bce33680f6b2feb5359666e414c777
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: positive affinity breaks maintenancing a host
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: positive affinity breaks maintenancing a host
......................................................................
core: positive affinity breaks maintenancing a host
I feel that this is best to describe with an example: vm1, vm2 running
with enforcing positive affinity group on host A.
When putting host A to maintenance, both VMs will try to migrate,
and fail because they're violating the affinity constraints.
the host is stuck on preparing for maint.
The fix ignores the host when it's in preparing for maint status.
Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e
Bug-Url: https://bugzilla.redhat.com/1084794
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit cb27efb5b9561420da8ecb7c44a3b4013c126acb)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: allow 2% gap in host low swap
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: allow 2% gap in host low swap
......................................................................
core: allow 2% gap in host low swap
This patch change the computation of low swap memory such that it allows
a 2% gap between the configured low swap value
(LogPhysicalMemoryThresholdInMB) and the actual one in order to prevent
th engine log to be flooded with warning when the actual value is OK.
Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135909
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Don't write empty description/comment to OVF
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Don't write empty description/comment to OVF
......................................................................
core: Don't write empty description/comment to OVF
Currently when we generate OVF files we write the description and
comment properties of the VM even if they are null. As a result when a
VM without a description or comment is re-imported it has an empty
string a value (instead of null) for these properties. This patch
changes the OVF writer so that it won't write the description or comment
properties if they are null.
Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9
Bug-Url: https://bugzilla.redhat.com/1145466
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit cbd16554817f0373df18018bd65795412972544f)
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: don't allow to create VM with balloon on ppc64
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: don't allow to create VM with balloon on ppc64
......................................................................
engine: don't allow to create VM with balloon on ppc64
Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab
Bug-Url: https://bugzilla.redhat.com/1127677
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 102 insertions(+), 13 deletions(-)
Approvals:
Jiří Moskovčák: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months